You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by "Brian Topping (JIRA)" <ji...@apache.org> on 2012/04/28 07:35:54 UTC

[jira] [Closed] (WICKET-362) Add ability to manage disabled items from subclasses of AbstractChoice

     [ https://issues.apache.org/jira/browse/WICKET-362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Topping closed WICKET-362.
--------------------------------

    
> Add ability to manage disabled items from subclasses of AbstractChoice
> ----------------------------------------------------------------------
>
>                 Key: WICKET-362
>                 URL: https://issues.apache.org/jira/browse/WICKET-362
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 2.0 branch (discontinued)
>            Reporter: Brian Topping
>            Assignee: Jean-Baptiste Quenot
>             Fix For: 1.3.0-beta2
>
>         Attachments: AbstractChoice.patch
>
>
> AbstractChoice does almost everything but disabled items.  This patch adds that ability.
> This is my first patch to Wicket.  I had some question about whether to include a default implementation for isDisabled(), but that would have required a Map to be supplied.  Then I started wondering about whether four more ctors should be provided to pass in the map.  Then I decided it was better managed by the subclass.  It can always be improved later.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira