You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by sunchao <gi...@git.apache.org> on 2017/03/28 04:50:31 UTC
[GitHub] thrift pull request #1226: THRIFT-4147: Rust: protocol should accept transpo...
GitHub user sunchao opened a pull request:
https://github.com/apache/thrift/pull/1226
THRIFT-4147: Rust: protocol should accept transports with non-static \u2026
\u2026lifetime
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunchao/thrift non-static-transport
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/1226.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1226
----
commit d250ad7ce51032f3087ccc3ff8a5141a7cd39a50
Author: Chao Sun <su...@apache.org>
Date: 2017-03-12T19:21:05Z
THRIFT-4147: Rust: protocol should accept transports with non-static lifetime
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1226: THRIFT-4147: Rust: protocol should accept transports wit...
Posted by sunchao <gi...@git.apache.org>.
Github user sunchao commented on the issue:
https://github.com/apache/thrift/pull/1226
cc @allengeorge to take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1226: THRIFT-4147: Rust: protocol should accept transports wit...
Posted by allengeorge <gi...@git.apache.org>.
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1226
Will take a look today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1226: THRIFT-4147: Rust: protocol should accept transports wit...
Posted by allengeorge <gi...@git.apache.org>.
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1226
@Jens-G This looks good to me. Can it be merged?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift issue #1226: THRIFT-4147: Rust: protocol should accept transports wit...
Posted by allengeorge <gi...@git.apache.org>.
Github user allengeorge commented on the issue:
https://github.com/apache/thrift/pull/1226
Note that I've tested it against master, and all the rust tests and cross-tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] thrift pull request #1226: THRIFT-4147: Rust: protocol should accept transpo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/thrift/pull/1226
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---