You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2020/02/04 12:08:19 UTC
[GitHub] [servicecomb-service-center] ChinX opened a new pull request #628:
[SCB-1743] [Syncer] Supports synchronization in a single direction
ChinX opened a new pull request #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628
After PR #627
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls edited a comment on issue
#628: [SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628#issuecomment-582288764
[](https://coveralls.io/builds/28977133)
Coverage increased (+0.8%) to 60.448% when pulling **7ff1a42d4fc72bc8018b989ff878eb92ed6e38eb on ChinX:syncer** into **ab4ec2eef3ffe6a24a55e833792520cbf05cc322 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] ChinX closed pull request #628:
[SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
ChinX closed pull request #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] zenlint commented on issue #628:
[SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
zenlint commented on issue #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628#issuecomment-603288675
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls edited a comment on issue
#628: [SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628#issuecomment-582288764
[](https://coveralls.io/builds/28979473)
Coverage increased (+0.8%) to 60.487% when pulling **eaffd5a42db1b2ad85c3a93f1eae0ac9a6e74a3c on ChinX:syncer** into **ab4ec2eef3ffe6a24a55e833792520cbf05cc322 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls commented on issue #628:
[SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628#issuecomment-582288764
[](https://coveralls.io/builds/28537411)
Coverage increased (+0.7%) to 60.344% when pulling **9c6acebea0b332a8b6dacafa8a3a02aca6dc5c37 on ChinX:syncer** into **85dc71bdc30cb3a226170b99c98e8e3df6cc5c78 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] zenlint merged pull request #628:
[SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
zenlint merged pull request #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue
#628: [SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628#issuecomment-583706747
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=h1) Report
> Merging [#628](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/85dc71bdc30cb3a226170b99c98e8e3df6cc5c78?src=pr&el=desc) will **increase** coverage by `0.85%`.
> The diff coverage is `89.71%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
+ Coverage 57.12% 57.97% +0.85%
==========================================
Files 207 212 +5
Lines 16062 16215 +153
==========================================
+ Hits 9175 9401 +226
+ Misses 6220 6147 -73
Partials 667 667
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/pkg/utils/atomic\_bool.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hdG9taWNfYm9vbC5nbw==) | `100% <100%> (ø)` | |
| [syncer/task/idle/idle.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svaWRsZS9pZGxlLmdv) | `100% <100%> (ø)` | |
| [syncer/task/task.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGFzay5nbw==) | `100% <100%> (ø)` | |
| [syncer/task/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGlja2VyL3RpY2tlci5nbw==) | `100% <100%> (ø)` | |
| [syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv) | `56.25% <57.14%> (-7.39%)` | :arrow_down: |
| [syncer/config/verify.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy92ZXJpZnkuZ28=) | `81.9% <81.9%> (ø)` | |
| [syncer/config/merge.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9tZXJnZS5nbw==) | `92.53% <92.53%> (ø)` | |
| [syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=) | `86.27% <93.33%> (+39.69%)` | :arrow_up: |
| [server/plugin/pkg/discovery/etcd/indexer\_cache.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvZGlzY292ZXJ5L2V0Y2QvaW5kZXhlcl9jYWNoZS5nbw==) | `78.94% <0%> (-9.29%)` | :arrow_down: |
| ... and [21 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=footer). Last update [85dc71b...7ff1a42](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] ChinX opened a new pull request #628:
[SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
ChinX opened a new pull request #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628
Base on PR #627
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls edited a comment on issue
#628: [SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628#issuecomment-582288764
[](https://coveralls.io/builds/28603058)
Coverage increased (+0.7%) to 60.384% when pulling **9c6acebea0b332a8b6dacafa8a3a02aca6dc5c37 on ChinX:syncer** into **85dc71bdc30cb3a226170b99c98e8e3df6cc5c78 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] codecov-io commented on issue #628:
[SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628#issuecomment-583706747
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=h1) Report
> Merging [#628](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/85dc71bdc30cb3a226170b99c98e8e3df6cc5c78?src=pr&el=desc) will **increase** coverage by `0.82%`.
> The diff coverage is `89.75%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #628 +/- ##
==========================================
+ Coverage 57.12% 57.94% +0.82%
==========================================
Files 207 212 +5
Lines 16062 16310 +248
==========================================
+ Hits 9175 9451 +276
+ Misses 6220 6192 -28
Partials 667 667
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/pkg/utils/atomic\_bool.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hdG9taWNfYm9vbC5nbw==) | `100% <100%> (ø)` | |
| [syncer/task/idle/idle.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svaWRsZS9pZGxlLmdv) | `100% <100%> (ø)` | |
| [syncer/task/task.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGFzay5nbw==) | `100% <100%> (ø)` | |
| [syncer/task/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3Rhc2svdGlja2VyL3RpY2tlci5nbw==) | `100% <100%> (ø)` | |
| [syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv) | `56.25% <57.14%> (-7.39%)` | :arrow_down: |
| [syncer/config/verify.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy92ZXJpZnkuZ28=) | `81.9% <81.9%> (ø)` | |
| [syncer/config/merge.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9tZXJnZS5nbw==) | `92.53% <92.53%> (ø)` | |
| [syncer/config/config.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c3luY2VyL2NvbmZpZy9jb25maWcuZ28=) | `86.27% <93.33%> (+39.69%)` | :arrow_up: |
| [server/handler/accesslog/handler.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree#diff-c2VydmVyL2hhbmRsZXIvYWNjZXNzbG9nL2hhbmRsZXIuZ28=) | `29.09% <0%> (-21.82%)` | :arrow_down: |
| ... and [17 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/628/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=footer). Last update [85dc71b...9c6aceb](https://codecov.io/gh/apache/servicecomb-service-center/pull/628?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] coveralls edited a comment on issue
#628: [SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628#issuecomment-582288764
[](https://coveralls.io/builds/29573881)
Coverage decreased (-0.06%) to 60.36% when pulling **e84444575ed14c41957400208ba87c64cd28d732 on ChinX:syncer** into **e851bb5de3ddc31d44a5136eb989193ae42b1562 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] ChinX opened a new pull request #628:
[SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
ChinX opened a new pull request #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628
Base on PR #627
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [servicecomb-service-center] ChinX closed pull request #628:
[SCB-1743] [Syncer] Supports synchronization in a single direction
Posted by GitBox <gi...@apache.org>.
ChinX closed pull request #628: [SCB-1743] [Syncer] Supports synchronization in a single direction
URL: https://github.com/apache/servicecomb-service-center/pull/628
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services