[GitHub] [superset] Damans227 commented on a change in pull request #17653: chore: migrate AsyncSelect component from jsx to tsx

[GitBox <gi...@apache.org>]

Damans227 commented on a change in pull request #17653:
URL: https://github.com/apache/superset/pull/17653#discussion_r762642815



##########
File path: superset-frontend/src/components/AsyncSelect/index.jsx
##########
@@ -29,6 +29,7 @@ const propTypes = {
   mutator: PropTypes.func.isRequired,
   onAsyncError: PropTypes.func,
   value: PropTypes.oneOfType([
+    PropTypes.string,

Review comment:
       Adding `string` as one of the types for the `value` prop to fix the following error in the `QuerySearch` component:
   
   ```
   
   Error: src/SqlLab/components/QuerySearch/index.tsx(193,13): error TS2322: Type 'string' is not assignable to type 'number | (number | null)[] | null | undefined'.
   Error: src/SqlLab/components/QuerySearch/index.tsx(202,13): error TS2322: Type 'string' is not assignable to type 'number | (number | null)[] | null | undefined'.
   
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org