You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "RobertIndie (via GitHub)" <gi...@apache.org> on 2023/02/21 11:44:17 UTC
[GitHub] [pulsar-site] RobertIndie opened a new pull request, #430: [Improove][doc] Add missing examples for java client
RobertIndie opened a new pull request, #430:
URL: https://github.com/apache/pulsar-site/pull/430
### Modification
* Add missing example codes for the java client
* Remove `Configure messages` section in the producer doc because it's already covered in `Send mesasges`
I think we also could delete [Send messages with customized metadata section](https://pulsar.apache.org/docs/next/client-libraries-producers/#send-messages-with-customized-metadata) because it's already covered in `Send mesasges`
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [x] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] RobertIndie merged pull request #430: [Improve][doc] Add missing examples for java client
Posted by "RobertIndie (via GitHub)" <gi...@apache.org>.
RobertIndie merged PR #430:
URL: https://github.com/apache/pulsar-site/pull/430
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on a diff in pull request #430: [Improove][doc] Add missing examples for java client
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on code in PR #430:
URL: https://github.com/apache/pulsar-site/pull/430#discussion_r1113743161
##########
docs/client-libraries-producers.md:
##########
@@ -11,24 +11,44 @@ import TabItem from '@theme/TabItem';
After setting up your clients, you can explore more to start working with [producers](concepts-clients.md#producers).
+## Create the producer
-## Configure messages
+This example shows how to create a producer:
Review Comment:
```suggestion
This example shows how to create a producer.
```
Keep consistent on punctuation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org