You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2023/01/02 07:07:55 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request, #6005: Support to resize uploaded volume during attach
Pearl1594 opened a new pull request, #6005:
URL: https://github.com/apache/cloudstack/pull/6005
### Description
This PR addresses #5906
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [X] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
### Screenshots (if appropriate):
### How Has This Been Tested?
Uploaded a volume with custom disk offering,
Attach the volume to a VM, it performs a resize operation on attach.
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1352110242
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 4948
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize volume during upload
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1739620250
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1380411881
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368239455
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#discussion_r1059374000
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -377,7 +396,31 @@ public VolumeVO uploadVolume(UploadVolumeCmd cmd) throws ResourceAllocationExcep
RegisterVolumePayload payload = new RegisterVolumePayload(cmd.getUrl(), cmd.getChecksum(), format);
vol.addPayload(payload);
- volService.registerVolume(vol, store);
+ return registerVolume(vol, store, sizeInGB);
+ }
+
+ VolumeVO registerVolume(VolumeInfo vol, DataStore store, Long sizeInGB ) {
+ VolumeVO volume = _volsDao.findById(vol.getId());
+ try {
+ AsyncCallFuture<VolumeApiResult> future = volService.registerVolume(vol, store);
+ VolumeApiResult result = future.get();
+ if (result.isFailed()) {
+ s_logger.warn("Failed to register the volume");
+ String details = "";
+ if (result.getResult() != null && !result.getResult().isEmpty()) {
+ details = result.getResult();
+ }
+ throw new CloudRuntimeException(details);
+ }
+ if (!Objects.equals(sizeInGB, vol.getSize())) {
+ if (sizeInGB !=null) {
+ volume.setSize(sizeInGB * GiB_TO_BYTES);
+ _volsDao.persist(volume);
+ }
+ }
Review Comment:
```suggestion
if (! (sizeInGB ==null || Objects.equals(sizeInGB, vol.getSize())) {
volume.setSize(sizeInGB * GiB_TO_BYTES);
_volsDao.persist(volume);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1272245574
@Pearl1594 can you resolve the conflicts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1348840086
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6005)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL) [1 Code Smell](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1383946481
@blueorangutan test keepenv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368039487
<b>Trillian test result (tid-5704)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41637 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6005-t5704-xenserver-71.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 729.63 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368220310
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 5148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #6005: Support to resize uploaded volume during attach
URL: https://github.com/apache/cloudstack/pull/6005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6005: Support to resize volume during upload
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1682123740
moved to 4.19.0.0 milestone as this is an enhancement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6005: Support to resize volume during upload
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1739476710
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1354573729
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#discussion_r1059650638
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -377,7 +396,29 @@ public VolumeVO uploadVolume(UploadVolumeCmd cmd) throws ResourceAllocationExcep
RegisterVolumePayload payload = new RegisterVolumePayload(cmd.getUrl(), cmd.getChecksum(), format);
vol.addPayload(payload);
- volService.registerVolume(vol, store);
+ return registerVolume(vol, store, sizeInGB);
+ }
+
+ VolumeVO registerVolume(VolumeInfo vol, DataStore store, Long sizeInGB ) {
+ VolumeVO volume = _volsDao.findById(vol.getId());
+ try {
+ AsyncCallFuture<VolumeApiResult> future = volService.registerVolume(vol, store);
+ VolumeApiResult result = future.get();
+ if (result.isFailed()) {
+ s_logger.warn("Failed to register the volume");
+ String details = "";
+ if (result.getResult() != null && !result.getResult().isEmpty()) {
+ details = result.getResult();
+ }
+ throw new CloudRuntimeException(details);
+ }
+ if (! (sizeInGB ==null || Objects.equals(sizeInGB, vol.getSize())) {
Review Comment:
```suggestion
if (! (sizeInGB ==null || Objects.equals(sizeInGB, vol.getSize()))) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368219430
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368700109
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland closed pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland closed pull request #6005: Support to resize uploaded volume during attach
URL: https://github.com/apache/cloudstack/pull/6005
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1253366183
@Pearl1594 you have a conflict :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1354406684
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1349008839
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368725513
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize volume during upload
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1584597356
@weizhouapache any way forward with this? Should we visit this on thursday?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a diff in pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on code in PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#discussion_r856540990
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -337,6 +338,20 @@ protected VolumeApiServiceImpl() {
_gson = GsonHelper.getGsonLogger();
}
+ private void validateDiskSize(DiskOfferingVO diskOffering, Long sizeInGB) {
+ if (diskOffering != null && diskOffering.isCustomized()) {
Review Comment:
We can invert the if and add a return statement to reduce code indentation.
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -2269,8 +2316,19 @@ public Volume attachVolumeToVM(Long vmId, Long volumeId, Long deviceId) {
vol = _volsDao.findById((Long)jobResult);
}
}
- return vol;
}
+
+ Long hostId = null;
+ if (vm.getHostId() != null) {
+ hostId = vm.getHostId();
+ } else if (vm.getLastHostId() != null) {
+ hostId = vm.getLastHostId();
+ }
+
+ if (vol != null && storeSize != null && hostId != null) {
Review Comment:
We can use `ObjectUtils#allNotNull` here.
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -364,7 +383,31 @@ public VolumeVO uploadVolume(UploadVolumeCmd cmd) throws ResourceAllocationExcep
RegisterVolumePayload payload = new RegisterVolumePayload(cmd.getUrl(), cmd.getChecksum(), cmd.getFormat());
vol.addPayload(payload);
- volService.registerVolume(vol, store);
+ return registerVolume(vol, store, sizeInGB);
+ }
+
+ VolumeVO registerVolume(VolumeInfo vol, DataStore store, Long sizeInGB ) {
+ VolumeVO volume = _volsDao.findById(vol.getId());
+ try {
+ AsyncCallFuture<VolumeApiResult> future = volService.registerVolume(vol, store);
+ VolumeApiResult result = future.get();
+ if (result.isFailed()) {
+ s_logger.warn("Failed to register the volume");
+ String details = "";
+ if (result.getResult() != null && !result.getResult().isEmpty()) {
+ details = result.getResult();
+ }
+ throw new CloudRuntimeException(details);
+ }
+ if (!Objects.equals(sizeInGB, vol.getSize())) {
+ if (sizeInGB !=null) {
+ volume.setSize(sizeInGB * GiB_TO_BYTES);
+ _volsDao.persist(volume);
+ }
+ }
+ } catch (Exception e) {
+ throw new CloudRuntimeException(String.format("Failed to register volume due to - %s", e.getMessage()), e);
Review Comment:
We can add some info about the volume here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support to resize volume during upload [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-2066168300
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1380413485
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize volume during upload
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1398064362
> > Please note that this change is only on the API level - no UI. There is a new parameter 'size' to the 'upload volume' command and you're able to customize the volume size during upload. The problem is I was able to upload a 1.3 GB image in a 1 GB data volume - I think there must be a check for this. Can be reproduced with the following cloudmonkey command:
> > upload volume name=centos7 url=https://cloud.centos.org/centos/7/images/CentOS-7-x86_64-GenericCloud-1706.qcow2 zoneid= diskofferingid= format=QCOW2 size=1
>
> it might be different to check the size before the template is uploaded (in ssvm). the workaround might be: after the template upload, if the new size is smaller than actual size, use the actual size as volume size, otherwise use the new size. cc @DaanHoogland @vladimirpetrov
agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1383856159
@blueorangutan test keepenv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1348711798
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1351984928
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1367748349
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368727619
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6005)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1380564093
@blueorangutan test keepenv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1397231963
Please note that this change is only on the API level - no UI. There is a new parameter 'size' to the 'upload volume' command and you're able to customize the volume size during upload. The problem is I was able to upload a 1.3 GB image in a 1 GB data volume - I think there must be a check for this. Can be reproduced with the following cloudmonkey command:
upload volume name=centos7 url=https://cloud.centos.org/centos/7/images/CentOS-7-x86_64-GenericCloud-1706.qcow2 zoneid=<zoneID> diskofferingid=<custom disk offering id> format=QCOW2 size=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1367520992
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368047303
<b>Trillian test result (tid-5705)</b>
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 43120 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6005-t5705-vmware-67u3.zip
Smoke tests completed. 106 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1348883460
Packaging result: :heavy_check_mark: el7 :heavy_multiplication_x: el8 :heavy_check_mark: debian :heavy_multiplication_x: suse15. SL-JID 4898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1351983433
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support to resize volume during upload [cloudstack]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1754902412
Is this worth rebooting @Pearl1594 and can you advise for 4.18 or 4.19/main?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1380547075
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6005)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6005: Support to resize volume during upload
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1405065990
@DaanHoogland
we need to revisit this PR after 4.18 release.
I have added the UI support and fixed a critical bug.
However , it still does not work. the issues are
(1) in DB/UI, the volume has new size (I set to 11GB), but on secondary storage, it is still the old size (8GB in my testing)
```
# qemu-img info /mnt/secstoragetmp/volumes/2/498/b10834c2-8b11-33a5-add9-a2cc68f7f148.qcow2
image: /mnt/secstoragetmp/volumes/2/498/b10834c2-8b11-33a5-add9-a2cc68f7f148.qcow2
file format: qcow2
virtual size: 8 GiB (8589934592 bytes)
disk size: 1.65 GiB
cluster_size: 65536
Format specific information:
compat: 0.10
compression type: zlib
refcount bits: 16
```
(2) after attaching it to a vm, the volume is copied to primary storage. however, the size is still not changed (=old size)
```
# qemu-img info /mnt/657524e2-065b-3ca8-9e97-746b3c7d17db/2792282d-1e69-40a7-9072-206c7ff133f5
image: /mnt/657524e2-065b-3ca8-9e97-746b3c7d17db/2792282d-1e69-40a7-9072-206c7ff133f5
file format: qcow2
virtual size: 8 GiB (8589934592 bytes)
disk size: 1.65 GiB
cluster_size: 65536
Format specific information:
compat: 0.10
compression type: zlib
refcount bits: 16
```
In short, volume is never resized (on KVM). I did not see any log to resize the volume.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1348710549
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on code in PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#discussion_r1059374723
##########
server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java:
##########
@@ -364,7 +383,31 @@ public VolumeVO uploadVolume(UploadVolumeCmd cmd) throws ResourceAllocationExcep
RegisterVolumePayload payload = new RegisterVolumePayload(cmd.getUrl(), cmd.getChecksum(), cmd.getFormat());
vol.addPayload(payload);
- volService.registerVolume(vol, store);
+ return registerVolume(vol, store, sizeInGB);
+ }
+
+ VolumeVO registerVolume(VolumeInfo vol, DataStore store, Long sizeInGB ) {
+ VolumeVO volume = _volsDao.findById(vol.getId());
+ try {
+ AsyncCallFuture<VolumeApiResult> future = volService.registerVolume(vol, store);
+ VolumeApiResult result = future.get();
+ if (result.isFailed()) {
+ s_logger.warn("Failed to register the volume");
+ String details = "";
+ if (result.getResult() != null && !result.getResult().isEmpty()) {
+ details = result.getResult();
+ }
+ throw new CloudRuntimeException(details);
+ }
+ if (!Objects.equals(sizeInGB, vol.getSize())) {
+ if (sizeInGB !=null) {
+ volume.setSize(sizeInGB * GiB_TO_BYTES);
+ _volsDao.persist(volume);
+ }
+ }
+ } catch (Exception e) {
+ throw new CloudRuntimeException(String.format("Failed to register volume due to - %s", e.getMessage()), e);
Review Comment:
@GutoVeronezi what do you expect? Keeping in mind that the upload/registering failed, so effectively there is no volume to speak about.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368770431
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6005?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6005](https://codecov.io/gh/apache/cloudstack/pull/6005?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8fe4f19) into [main](https://codecov.io/gh/apache/cloudstack/commit/def7ce655df38c89f3dffed1da3ba785d8e2ee3e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (def7ce6) will **increase** coverage by `0.03%`.
> The diff coverage is `16.66%`.
```diff
@@ Coverage Diff @@
## main #6005 +/- ##
============================================
+ Coverage 11.50% 11.54% +0.03%
+ Complexity 7534 7518 -16
============================================
Files 2492 2494 +2
Lines 246775 246813 +38
Branches 38559 38539 -20
============================================
+ Hits 28391 28485 +94
+ Misses 214787 214647 -140
- Partials 3597 3681 +84
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6005?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ck/engine/subsystem/api/storage/VolumeService.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2FwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9lbmdpbmUvc3Vic3lzdGVtL2FwaS9zdG9yYWdlL1ZvbHVtZVNlcnZpY2UuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...e/cloudstack/storage/volume/VolumeServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2Uvdm9sdW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N0b3JhZ2Uvdm9sdW1lL1ZvbHVtZVNlcnZpY2VJbXBsLmphdmE=) | `2.32% <0.00%> (ø)` | |
| [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `6.75% <0.00%> (-0.01%)` | :arrow_down: |
| [...n/java/com/cloud/storage/VolumeApiServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvVm9sdW1lQXBpU2VydmljZUltcGwuamF2YQ==) | `12.86% <17.85%> (+0.01%)` | :arrow_up: |
| [...va/com/cloud/upgrade/dao/DatabaseAccessObject.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9EYXRhYmFzZUFjY2Vzc09iamVjdC5qYXZh) | `0.00% <0.00%> (-97.50%)` | :arrow_down: |
| [...work/as/dao/AutoScaleVmGroupStatisticsDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9uZXR3b3JrL2FzL2Rhby9BdXRvU2NhbGVWbUdyb3VwU3RhdGlzdGljc0Rhb0ltcGwuamF2YQ==) | `0.00% <0.00%> (-96.62%)` | :arrow_down: |
| [...ain/java/com/cloud/upgrade/dao/DbUpgradeUtils.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9EYlVwZ3JhZGVVdGlscy5qYXZh) | `0.00% <0.00%> (-92.31%)` | :arrow_down: |
| [...d/network/as/dao/AutoScaleVmGroupVmMapDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9uZXR3b3JrL2FzL2Rhby9BdXRvU2NhbGVWbUdyb3VwVm1NYXBEYW9JbXBsLmphdmE=) | `0.00% <0.00%> (-65.79%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade444to450.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDQ0dG80NTAuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| [...in/java/com/cloud/upgrade/dao/Upgrade453to460.java](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91cGdyYWRlL2Rhby9VcGdyYWRlNDUzdG80NjAuamF2YQ==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
| ... and [128 more](https://codecov.io/gh/apache/cloudstack/pull/6005/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1367748425
@DaanHoogland a Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1152328506
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize volume during upload
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1739481398
@Pearl1594 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1349009839
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1350390695
<b>Trillian test result (tid-5490)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42319 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6005-t5490-kvm-centos7.zip
Smoke tests completed. 104 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 578.90 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1354405573
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1380546443
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1367544228
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 5131
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368046622
<b>Trillian test result (tid-5706)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42913 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6005-t5706-kvm-centos7.zip
Smoke tests completed. 105 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 578.75 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1367520859
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6005: Support to resize volume during upload
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1398042795
> Please note that this change is only on the API level - no UI. There is a new parameter 'size' to the 'upload volume' command and you're able to customize the volume size during upload. The problem is I was able to upload a 1.3 GB image in a 1 GB data volume - I think there must be a check for this. Can be reproduced with the following cloudmonkey command:
>
> upload volume name=centos7 url=https://cloud.centos.org/centos/7/images/CentOS-7-x86_64-GenericCloud-1706.qcow2 zoneid= diskofferingid= format=QCOW2 size=1
it might be different to check the size before the template is uploaded (in ssvm).
the workaround might be: after the template upload, if the new size is smaller than actual size, use the actual size as volume size, otherwise use the new size.
cc @DaanHoogland @vladimirpetrov
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6005: Support to resize volume during upload
Posted by sonarcloud.
sonarcloud[bot] commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1405164316
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6005)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6005&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6005&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6005&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6005: Support to resize uploaded volume during attach
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1368219636
@DaanHoogland a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6005: Support to resize volume during upload
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1639615099
ping @Pearl1594 is this still relevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #6005: Support to resize volume during upload
Posted by "Pearl1594 (via GitHub)" <gi...@apache.org>.
Pearl1594 commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1640308309
I believe it is still relevant, it was more of an enhancement request. I think there is an issue based on Wei's comment, I'll need to spend some time on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support to resize volume during upload [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #6005:
URL: https://github.com/apache/cloudstack/pull/6005#issuecomment-1787252771
moving to 4.20 due to lack of resources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org