You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/06 01:31:04 UTC

[GitHub] [pulsar] addisonj opened a new pull request #6489: [broker] Timeout API calls in BrokerService

addisonj opened a new pull request #6489: [broker] Timeout API calls in BrokerService
URL: https://github.com/apache/pulsar/pull/6489
 
 
   See #6416. This change ensures that all futures within BrokerService
   have a guranteed timeout. As stated in #6416, we see cases where it
   appears that loading or creating a topic fails to resolve the future for
   unknown reasons. It appears that these futures *may* not be returning.
   
   
   
   ### Motivation
   This commit just adds a deadline for all the futures created in brokerService.
   
   This seems like a sane change to make to ensure that these futures
   finish, however, it still isn't understood under what conditions these
   futures may not be returning, so this fix is mostly a workaround for
   some underlying issues.
   
   ### Verifying this change
   
   
   This change is already covered by existing tests, such as the broker tests
   
   *(or)*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): n
     - The public API:n
     - The schema: n
     - The default values of configurations: n
     - The wire protocol:n
     - The rest endpoints: n
     - The admin cli options: n
     - Anything that affects deployment: n
   
   ### Documentation
   
     - Does this pull request introduce a new feature? n
     - If yes, how is the feature documented? n/a
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] addisonj commented on issue #6489: [broker] Timeout API calls in BrokerService

Posted by GitBox <gi...@apache.org>.
addisonj commented on issue #6489: [broker] Timeout API calls in BrokerService
URL: https://github.com/apache/pulsar/pull/6489#issuecomment-595564081
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] addisonj commented on issue #6489: [broker] Timeout API calls in BrokerService

Posted by GitBox <gi...@apache.org>.
addisonj commented on issue #6489: [broker] Timeout API calls in BrokerService
URL: https://github.com/apache/pulsar/pull/6489#issuecomment-595575713
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie commented on a change in pull request #6489: [broker] Timeout API calls in BrokerService

Posted by GitBox <gi...@apache.org>.
sijie commented on a change in pull request #6489: [broker] Timeout API calls in BrokerService
URL: https://github.com/apache/pulsar/pull/6489#discussion_r389185936
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
 ##########
 @@ -732,6 +733,20 @@ public void unloadNamespaceBundlesGracefully() {
         return future;
     }
 
+    private <T> CompletableFuture<T> futureWithDeadline(Long delay, TimeUnit unit, Exception exp) {
 
 Review comment:
   Can we move this into FutureUtil class?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #6489: [broker] Timeout API calls in BrokerService

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6489: [broker] Timeout API calls in BrokerService
URL: https://github.com/apache/pulsar/pull/6489
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services