You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by muratsu <gi...@git.apache.org> on 2015/02/04 01:15:53 UTC
[GitHub] cordova-wp8 pull request: CB-8412
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-wp8/pull/75
CB-8412
- Created a `npm run jshint` command & integrate into `npm run test`
- Created jshint rules files for spec and rest of the repo
- Added node_module jshint to repo
- Fixed all jshint issues
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-wp8 CB-8412
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-wp8/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 10db8dfd36209c01db72efe61cc261ce7df6385c
Author: Murat Sutunc <mu...@microsoft.com>
Date: 2015-02-03T22:00:10Z
CB-8412 Enable jshint for wp8 platform
commit 656bf2fc60cea42931dbfc05da395709cf5c553c
Author: Murat Sutunc <mu...@microsoft.com>
Date: 2015-02-03T23:21:28Z
CB-8412 Fix all jshint issues for WP8 platform
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73208876
Not sure where you are seeing this error ... I see nothing in any of the failed build logs about Silverlight.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-72768317
Latest commit has broken the build.
https://ci.appveyor.com/project/Humbedooh/cordova-wp8/build/1.0.99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-72776758
We were previously using sync exec with shelljs. Looks like it was causing a time out as noted [here](http://documentup.com/arturadib/shelljs#command-reference/exec-command-options-callback). Converted them to async to fix the issue. Waiting for the next pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-wp8/pull/75
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73223016
This is an issue of AppVeyor itself and it should be [fixed now](http://help.appveyor.com/discussions/questions/921-support-for-silverlight-4-available). We need just another commit now to trigger the build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73285130
Ahh, finally we're all green on AppVeyor :rocket:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73196289
Hmm, who owns the test machine? I thought it was owned by infra, I couldn't find a way to configure it. It currently doesnt have Silverlight installed but looks like a week ago it had it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73195925
Infra has nothing to do with appveyor other than setting up the github integration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-wp8 pull request: CB-8412
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73194673
Turns out the build errors are unrelated. I'm seeing the following error on Appveyor console:
`C:\Program Files (x86)\MSBuild\Microsoft\WindowsPhone\v8.0\Microsoft.WindowsPhone.Common.targets(110,5): error : The Silverlight 4 SDK is not installed.` I'll open a separate INFRA issue, in the mean time can we go ahead with the merge. Lint changes are hard to rebase later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
Re: [GitHub] cordova-wp8 pull request: CB-8412
Posted by Jesse <pu...@gmail.com>.
http://www.appveyor.com/docs/installed-software
@purplecabbage
risingj.com
On Fri, Feb 6, 2015 at 1:28 AM, muratsu <gi...@git.apache.org> wrote:
> Github user muratsu commented on the pull request:
>
> https://github.com/apache/cordova-wp8/pull/75#issuecomment-73209662
>
> On build 103 you can see this error message:
> https://ci.appveyor.com/project/Humbedooh/cordova-wp8/build/1.0.103
> In order to see the failure, you have to pipe build output to test
> output, which is not desirable under normal circumstances - that's why I've
> changed it back to silent and it's not visible on 104.
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> For additional commands, e-mail: dev-help@cordova.apache.org
>
>
[GitHub] cordova-wp8 pull request: CB-8412
Posted by muratsu <gi...@git.apache.org>.
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-wp8/pull/75#issuecomment-73209662
On build 103 you can see this error message: https://ci.appveyor.com/project/Humbedooh/cordova-wp8/build/1.0.103
In order to see the failure, you have to pipe build output to test output, which is not desirable under normal circumstances - that's why I've changed it back to silent and it's not visible on 104.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org