You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/23 20:57:21 UTC

[GitHub] [arrow-datafusion] seddonm1 commented on a change in pull request #934: Update to sqlparser v 0.10.0

seddonm1 commented on a change in pull request #934:
URL: https://github.com/apache/arrow-datafusion/pull/934#discussion_r694303295



##########
File path: datafusion/src/sql/planner.rs
##########
@@ -1256,7 +1256,7 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
                     BinaryOperator::Minus => Ok(Operator::Minus),
                     BinaryOperator::Multiply => Ok(Operator::Multiply),
                     BinaryOperator::Divide => Ok(Operator::Divide),
-                    BinaryOperator::Modulus => Ok(Operator::Modulus),
+                    BinaryOperator::Modulo => Ok(Operator::Modulo),

Review comment:
       Seems to me like it is worth fixing everywhere consistently




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org