You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/31 13:18:02 UTC
[GitHub] [airflow] osule opened a new pull request, #25428: Remove WARN as an available logging level
osule opened a new pull request, #25428:
URL: https://github.com/apache/airflow/pull/25428
WARN is not an implemented logging level.
ex.gr. when an airflow component such as the scheduler or worker
is ran with `WARN` set for the `celery_logging_level`, the following exception is
raised in the underlying implementation in click library:
```
click.exceptions.BadParameter: 'WARN' is not one of 'DEBUG', 'INFO', 'WARNING', 'ERROR', 'CRITICAL', 'FATAL'.
```
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] osule commented on pull request #25428: Remove WARN as an available logging level
Posted by GitBox <gi...@apache.org>.
osule commented on PR #25428:
URL: https://github.com/apache/airflow/pull/25428#issuecomment-1203106718
@uranusjr That's new information. Thanks for sharing that.
@potiuk This breaks backward compatibility of the other libraries (ex.gr. fabric, gunicorn) supporting WARN
WARN currently throws a runtime exception that exits the process for the celery app.
Should we perform this mapping only for celery logging level or generally for other libraries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25428: Remove WARN as an available logging level
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25428:
URL: https://github.com/apache/airflow/pull/25428#issuecomment-1201692846
I think it would be necessary to find out where WARN level came from here? Surprisinglu it's not the same as WARNING (and that's where @uranusjr confusion comes from), but I guess there is a good reason WARN was there originally. I think we need to know if we are not breaking any compatibility here. Any good guesses why it could be WARN in the first place @osule ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #25428: Remove WARN as an available logging level
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #25428:
URL: https://github.com/apache/airflow/pull/25428#issuecomment-1249950482
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #25428: Remove WARN as an available logging level
Posted by GitBox <gi...@apache.org>.
uranusjr commented on PR #25428:
URL: https://github.com/apache/airflow/pull/25428#issuecomment-1201962217
`WARN` has always been a valid level ([still is in the implementation](https://github.com/python/cpython/blob/d2c1a9c76c001b18c14e50779b0ee41ea4ccf0b3/Lib/logging/__init__.py#L119)), but Python removed it from the documentation to discourage people from using it (and prefer `WARNING` instead). Celery likely has a more relaxed backward compatibility policy and removed it when it could break backward compatibility at some point (maybe 4.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] osule commented on pull request #25428: Remove WARN as an available logging level
Posted by GitBox <gi...@apache.org>.
osule commented on PR #25428:
URL: https://github.com/apache/airflow/pull/25428#issuecomment-1201293773
@uranusjr WARN is not a valid logging level in the standard library.
https://docs.python.org/3/library/logging.html#logging-level
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25428: Remove WARN as an available logging level
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25428:
URL: https://github.com/apache/airflow/pull/25428#issuecomment-1201694552
It looks like at least at some point in time WARN was a valid leve in Celery https://docs.celeryq.dev/en/4.4.1/_modules/logging.html
Any intelligent guesses what kind of backwards compatibility problem such removal might bring ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25428: Remove WARN as an available logging level
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25428:
URL: https://github.com/apache/airflow/pull/25428#issuecomment-1203124856
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #25428: Remove WARN as an available logging level
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #25428: Remove WARN as an available logging level
URL: https://github.com/apache/airflow/pull/25428
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org