You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "vogievetsky (via GitHub)" <gi...@apache.org> on 2026/07/23 22:14:44 UTC

[PR] feat: web console: add file uri tooltip to sample data view (druid)

vogievetsky opened a new pull request, #19741:
URL: https://github.com/apache/druid/pull/19741

   query the __file_uri system field if it is possible for the input source and show it in a tooltip


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] feat: web console: add file uri tooltip to sample data view (druid)

Posted by "vogievetsky (via GitHub)" <gi...@apache.org>.
vogievetsky commented on code in PR #19741:
URL: https://github.com/apache/druid/pull/19741#discussion_r3647031091


##########
web-console/src/utils/sampler.ts:
##########
@@ -285,6 +287,14 @@ export async function sampleForConnect(
     );
   }
 
+  const addFileUri = Boolean(
+    ioConfig.inputSource &&
+      getPossibleSystemFieldsForInputSource(ioConfig.inputSource).includes('__file_uri'),

Review Comment:
   Great spot! fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] feat: web console: add file uri tooltip to sample data view (druid)

Posted by "vogievetsky (via GitHub)" <gi...@apache.org>.
vogievetsky merged PR #19741:
URL: https://github.com/apache/druid/pull/19741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org


Re: [PR] feat: web console: add file uri tooltip to sample data view (druid)

Posted by "FrankChen021 (via GitHub)" <gi...@apache.org>.
FrankChen021 commented on code in PR #19741:
URL: https://github.com/apache/druid/pull/19741#discussion_r3645236731


##########
web-console/src/utils/sampler.ts:
##########
@@ -285,6 +287,14 @@ export async function sampleForConnect(
     );
   }
 
+  const addFileUri = Boolean(
+    ioConfig.inputSource &&
+      getPossibleSystemFieldsForInputSource(ioConfig.inputSource).includes('__file_uri'),

Review Comment:
   [P2] Include HTTP sources in the file-URI gate
   
   `getPossibleSystemFieldsForInputSource` returns no fields for `http`, even though `HttpInputSource` supports both `__file_uri` and `__file_path`. As a result this new gate never requests `__file_uri` for HTTP samples, so the tooltip is absent for the web console's common URL-based sample flow. Add HTTP to the supported-source mapping and cover the generated sampler request.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org