You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kan Zhang (JIRA)" <ji...@apache.org> on 2009/12/05 20:42:20 UTC
[jira] Created: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Adding a common token interface for both job token and delegation token
-----------------------------------------------------------------------
Key: HADOOP-6415
URL: https://issues.apache.org/jira/browse/HADOOP-6415
Project: Hadoop Common
Issue Type: New Feature
Components: security
Reporter: Kan Zhang
Assignee: Kan Zhang
Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6415:
------------------------------
Status: Patch Available (was: Open)
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c1250-17.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792438#action_12792438 ]
Hudson commented on HADOOP-6415:
--------------------------------
Integrated in Hadoop-Common-trunk #191 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/191/])
. Adds a common token interface for both job token and delegation token. Contributed by Kan Zhang.
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c1250-17.patch, c1250-19.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Jitendra Nath Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jitendra Nath Pandey updated HADOOP-6415:
-----------------------------------------
Attachment: HADOOP-6415-0_20.2.patch
Patch for 20 branch added.
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c1250-17.patch, c1250-19.patch, HADOOP-6415-0_20.2.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12791669#action_12791669 ]
Kan Zhang commented on HADOOP-6415:
-----------------------------------
> I'd rename convertToSecretKey to createSecretKey.
I named it convertToSecretKey() to emphasize the fact that the returned SecretKey is not generated locally but merely converted from the supplied byte[]. createSecretKey may mislead the user to think SecretManager contributes to the key generation in some other capacity. However, if you really like createSecretKey, I'll make the change.
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c1250-17.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6415:
------------------------------
Attachment: c1250-17.patch
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c1250-17.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792309#action_12792309 ]
Hudson commented on HADOOP-6415:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #122 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/122/])
. Adds a common token interface for both job token and delegation token. Contributed by Kan Zhang.
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c1250-17.patch, c1250-19.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786477#action_12786477 ]
Hadoop QA commented on HADOOP-6415:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12427057/c1250-17.patch
against trunk revision 887472.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/171/console
This message is automatically generated.
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c1250-17.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6415:
------------------------------
Attachment: c1250-19.patch
Attaching a patch that addresses Owen's comments.
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c1250-17.patch, c1250-19.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786478#action_12786478 ]
Kan Zhang commented on HADOOP-6415:
-----------------------------------
attached a patch that derives from an earlier draft patch of HADOOP-6373 (the Common part) and incorporates Owen's comments given there.
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c1250-17.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj Das updated HADOOP-6415:
--------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Kan!
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Fix For: 0.22.0
>
> Attachments: c1250-17.patch, c1250-19.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792107#action_12792107 ]
Hadoop QA commented on HADOOP-6415:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12428338/c1250-19.patch
against trunk revision 891511.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/216/console
This message is automatically generated.
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c1250-17.patch, c1250-19.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Kan Zhang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kan Zhang updated HADOOP-6415:
------------------------------
Status: Patch Available (was: Open)
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c1250-17.patch, c1250-19.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6415) Adding a common token interface for
both job token and delegation token
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6415:
----------------------------------
Status: Open (was: Patch Available)
This is looking good. Some points:
# I'd rename convertToSecretKey to createSecretKey.
# You need JavaDoc entries on the public methods of Token.
# You need JavaDoc description of the TokenIdentifier class.
> Adding a common token interface for both job token and delegation token
> -----------------------------------------------------------------------
>
> Key: HADOOP-6415
> URL: https://issues.apache.org/jira/browse/HADOOP-6415
> Project: Hadoop Common
> Issue Type: New Feature
> Components: security
> Reporter: Kan Zhang
> Assignee: Kan Zhang
> Attachments: c1250-17.patch
>
>
> Both job token and delegation token will be used by RPC.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.