You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Andres de la Peña (Jira)" <ji...@apache.org> on 2021/11/24 12:05:00 UTC

[jira] [Commented] (CASSANDRA-16878) Race in commit log replay can cause rejected mutations

    [ https://issues.apache.org/jira/browse/CASSANDRA-16878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448567#comment-17448567 ] 

Andres de la Peña commented on CASSANDRA-16878:
-----------------------------------------------

I have just rebased the patches without conflicts and CI is running again:
||PR||CI||
|[3.0 |https://github.com/apache/cassandra/pull/1165]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1164/workflows/82c45d1c-60f8-4bc4-9ba8-03fe7afc0793]|
|[3.11 |https://github.com/apache/cassandra/pull/1166]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1162/workflows/cd14e755-213d-4f22-bccb-e7f1c4194a63]|
|[4.0 |https://github.com/apache/cassandra/pull/1167]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1163/workflows/2f1c293b-e698-4d2c-9324-807b7d91aa4c] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1163/workflows/e81f9459-483e-4ca3-8866-43bb38fad565]|
|[trunk|https://github.com/apache/cassandra/pull/1168]|[j8|https://app.circleci.com/pipelines/github/adelapena/cassandra/1165/workflows/a2ee0d11-7b07-476a-b9a6-017135a6eec2] [j11|https://app.circleci.com/pipelines/github/adelapena/cassandra/1165/workflows/55e9c986-07b6-4953-bd39-fcd42107f4f3]|
|[dtest|https://github.com/apache/cassandra-dtest/pull/155]|

CI contains repeated runs of the new dtest.

> Race in commit log replay can cause rejected mutations
> ------------------------------------------------------
>
>                 Key: CASSANDRA-16878
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16878
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Local Write-Read Paths
>            Reporter: Andres de la Peña
>            Assignee: Andres de la Peña
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> We don't force order in the execution of replayed mutations and hence a mutation can move ahead of or behind a schema change it relies on (e.g. added/removed column), which can then cause it to be rejected because of a schema mismatch.
> To fix this, we need to identify schema mutations and make sure the log enforces their execution after all previous mutations have completed and before anything following is started.
> Schema mutations are [flushed|https://github.com/apache/cassandra/blob/cassandra-4.0.0/src/java/org/apache/cassandra/schema/SchemaKeyspace.java#L1266-L1271] after being applied, so this only would be a problem if the node abruptly stops before flushing the schema mutation.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org