[jira] [Commented] (YARN-12000) Fix flaky TestLeafQueue.testMaxApplicationsWithNodeLabels

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-12000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18122159#comment-18122159 ] 

ASF GitHub Bot commented on YARN-12000:
---------------------------------------

slfan1989 opened a new pull request, #8779:
URL: https://github.com/apache/hadoop/pull/8779

   ### Description of PR
   
   Fix a race in `TestLeafQueue.testMaxApplicationsWithNodeLabels` that can cause Mockito `WrongTypeOfReturnValue` errors.
   
   The test stubs `cs.getClusterResource()` after the scheduler has started, while background threads may access the same scheduler spy.
   
   Replace this stubbing with a test node registered in the scheduler's `NodeTracker`. This preserves the original cluster resource total and capacity assertions while avoiding concurrent stubbing.
   
   Observed CI failure:
   https://github.com/slfan1989/hadoop/actions/runs/37081719421/job/111086051586
   
   
   ### How was this patch tested?
   
   CI.
   
   ### For code changes:
   
   - [ ] Does the title of this PR start with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: Have the integration tests been executed and the endpoint
         declared according to the connector-specific documentation? *Note: Automated CI
         testing doesn't cover all cases so manual testing with cloud storage is still
         required.*
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   ### AI Tooling
   
   If an AI tool was used:
   
   - [ ] The PR includes the phrase "Contains content generated by <tool>"
         where <tool> is the name of the AI tool used.
   - [ ] My use of AI contributions follows the ASF legal policy
         https://www.apache.org/legal/generative-tooling.html
   




> Fix flaky TestLeafQueue.testMaxApplicationsWithNodeLabels
> ---------------------------------------------------------
>
>                 Key: YARN-12000
>                 URL: https://issues.apache.org/jira/browse/YARN-12000
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 3.6.0
>            Reporter: Shilun Fan
>            Assignee: Shilun Fan
>            Priority: Minor
>
> TestLeafQueue.testMaxApplicationsWithNodeLabels can fail with a Mockito WrongTypeOfReturnValue exception when configuring the scheduler spy after
> the scheduler has started.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org