You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@celix.apache.org by "xuzhenbao (via GitHub)" <gi...@apache.org> on 2023/10/19 12:22:05 UTC
[PR] Resolve address sanitizer error for `celix_filter_create` (celix)
xuzhenbao opened a new pull request, #673:
URL: https://github.com/apache/celix/pull/673
Fix issues #672
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve address sanitizer error for `celix_filter_create` (celix)
Posted by "xuzhenbao (via GitHub)" <gi...@apache.org>.
xuzhenbao merged PR #673:
URL: https://github.com/apache/celix/pull/673
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve address sanitizer error for `celix_filter_create` (celix)
Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes commented on code in PR #673:
URL: https://github.com/apache/celix/pull/673#discussion_r1367148183
##########
libs/utils/src/filter.c:
##########
@@ -165,7 +165,9 @@ static celix_filter_t * filter_parseNot(char * filterString, int * pos) {
}
child = filter_parseFilter(filterString, pos);
-
+ if(child == NULL){
Review Comment:
styling nitpick: missing some spaces.
```suggestion
if (child == NULL) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Resolve address sanitizer error for `celix_filter_create` (celix)
Posted by "pnoltes (via GitHub)" <gi...@apache.org>.
pnoltes commented on code in PR #673:
URL: https://github.com/apache/celix/pull/673#discussion_r1367150490
##########
libs/utils/src/filter.c:
##########
@@ -165,7 +165,9 @@ static celix_filter_t * filter_parseNot(char * filterString, int * pos) {
}
child = filter_parseFilter(filterString, pos);
-
+ if(child == NULL){
Review Comment:
I am planning to create a support develop branch for a 2.4.1 release next week and will also add the changes of this PR (cherry pick)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org