[jira] Updated: (EMPIREDB-71) Auto Increment Column Property that lives well with existing DataType.AUTOINC

["McKinley (JIRA)" <em...@incubator.apache.org>]

     [ https://issues.apache.org/jira/browse/EMPIREDB-71?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

McKinley updated EMPIREDB-71:
-----------------------------

    Attachment: empire-db-mckinley-autoinc-20-Jan-2010.patch

Here is the patch

> Auto Increment Column Property that lives well with existing DataType.AUTOINC
> -----------------------------------------------------------------------------
>
>                 Key: EMPIREDB-71
>                 URL: https://issues.apache.org/jira/browse/EMPIREDB-71
>             Project: Empire-DB
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: empire-db-2.0.7-incubating 
>            Reporter: McKinley
>         Attachments: empire-db-mckinley-autoinc-20-Jan-2010.patch
>
>   Original Estimate: 0.17h
>  Remaining Estimate: 0.17h
>
> Not all DBMS use only int for auto increment columns. There would be significant work involved in adding data type checks to all cases of auto increment for all DBMS. The is no auto increment column in my mind that is not some other standalone data type such as int, decimal or uniqueidentifier*. Therefore, the data type and auto increment properties of a column are and should be separate.
> This patch will create a new property for auto increment and change all the locations that checked for DataType.AUTOINC.  The isAutoIncrement() accessor method defers to DataType.AUTOINC making it compatible for all those who would like to continue to use DataType.AUTOINC.
> One stylistic question: are the 1) private member boolean autoinc and 2) accessor isAutoIncrement() and 3) method parameter autoinc the names and casing that you would have chosen?
> Thanks,
> McKinley
> *uniqueidentifier is not technically auto increment (it is not serial), but from the perspective of Empire-db it must be used as auto increment when it is part of a primary key.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.