You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Ma77Ball (via GitHub)" <gi...@apache.org> on 2025/11/26 12:46:45 UTC
[PR] feat(ui): add pagination and search for wide-column tables [texera]
Ma77Ball opened a new pull request, #4086:
URL: https://github.com/apache/texera/pull/4086
<!--
Thanks for sending a pull request (PR)! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
[Contributing to Texera](https://github.com/apache/texera/blob/main/CONTRIBUTING.md)
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is a work in progress, mark it as a draft on GitHub.
4. Please write your PR title to summarize what this PR proposes. We
are following the Conventional Commits style for PR titles as well.
5. Be sure to keep the PR description updated to reflect all changes.
-->
### What changes were proposed in this PR?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes. Here are some tips for you:
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
3. If it is a refactoring, could you explain what has been changed?
3. It would be helpful to include a before-and-after comparison using
screenshots or GIFs.
4. Please consider writing helpful notes for better and faster reviews.
-->
This PR adds a feature that enables Texera to efficiently handle tables with vast numbers of columns in the result panel.
This PR adds UI features that enable Texera to efficiently handle tables with large numbers of columns in the result viewer and related data preview components.
Specifically, this PR introduces:
1. Horizontal Column Pagination
1. "Next Columns" and "Previous Columns" buttons have been added.
2. Columns are now loaded in column windows (configurable size, default 25).
3. Prevents UI freezing or overflow when dealing with tables containing hundreds or thousands of columns.
2. Column Search Bar
1. A new search box allows users to filter or jump directly to column names.
2. When a column is found, that column window is automatically loaded and highlighted.
3. Useful for wide schemas such as:
1. large scientific datasets
2. logs with hundreds of attributes
3. denormalized tables or wide joins
3. Improvements to rendering performance
1. The frontend now only renders the visible subset of columns.
2. Reduces DOM load and improves React change detection speed.
### Any related issues, documentation, or discussions?
<!--
Please use this section to link to other resources if not mentioned already.
1. If this PR fixes an issue, please include `Fixes #1234`, `Resolves #1234.`
or `Closes #1234`. If it is only related, mention the issue number.
2. If there is design documentation, please add the link.
3. If there is a discussion on the mailing list, please add the link.
-->
Fixes: https://github.com/apache/texera/issues/3825
### How was this PR tested?
<!--
If tests were added, say so here. Or mention that if the PR
is tested with existing test cases. Please include/update test cases that
check the changes thoroughly, including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how
you tested step by step, ideally copy and paste-able, so that other reviewers can
test and check, and descendants can verify in the future. If tests were not added,
please describe why they were not added and/or why it was difficult to add.
-->
1. Ran a couple of CSV scan operators that produced a wide output table
2. Clicked through column windows in both directions
3. Using search to jump to:
- first column
- random middle column
- last column
### Was this PR authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this PR,
please include the phrase: 'Generated-by: ' followed by the name of the tool
and its version. If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2654541768
##########
frontend/src/app/workspace/component/result-panel/result-panel.component.ts:
##########
@@ -52,7 +52,7 @@ import { CompilationState } from "../../types/workflow-compiling.interface";
import { WorkflowFatalError } from "../../types/workflow-websocket.interface";
export const DEFAULT_WIDTH = 800;
-export const DEFAULT_HEIGHT = 300;
+export const DEFAULT_HEIGHT = 500;
Review Comment:
@aglinxinyuan Please merge this PR when you think it's ready.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3598526266
I suggest to add @aglinxinyuan to review the UI change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3672878174
Thanks, @Ma77Ball .
@kunwp1 Please review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3701623747
@carloea2 Please do as suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3702579480
Sorry my comment was for @Ma77Ball , not @carloea2 .
@Ma77Ball Please take care of the final comments before we an do the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "carloea2 (via GitHub)" <gi...@apache.org>.
carloea2 commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3701627298
> @carloea2 Please do as suggested.
Hello, sorry what should I do?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2578435797
##########
amber/src/main/scala/org/apache/texera/web/service/ExecutionResultService.scala:
##########
@@ -433,12 +433,27 @@ class ExecutionResultService(
storageUriOption match {
case Some(storageUri) =>
+ val (document, schemaOption) = DocumentFactory.openDocument(storageUri)
+ val virtualDocument = document.asInstanceOf[VirtualDocument[Tuple]]
+
+ val columns = if (request.columnLimit < Int.MaxValue && schemaOption.isDefined) {
Review Comment:
I think we don't need this if condition. Can you review the code to see if this condition is always true?
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html:
##########
@@ -25,6 +25,39 @@ <h4>Empty result set</h4>
<div
[hidden]="!currentColumns"
class="result-table">
+ <div
+ class="column-navigation"
+ style="margin-bottom: 8px; display: flex; justify-content: flex-end; gap: 8px">
+ <button
+ nz-button
+ nzType="default"
+ (click)="onColumnShiftLeft()"
+ [disabled]="currentColumnOffset === 0">
+ <i
+ nz-icon
+ nzType="left"></i>
+ Previous Columns
+ </button>
+ <button
+ nz-button
+ nzType="default"
+ (click)="onColumnShiftRight()"
+ [disabled]="!currentColumns || currentColumns.length < columnLimit">
+ Next Columns
+ <i
+ nz-icon
+ nzType="right"></i>
+ </button>
+ </div>
+ <div
+ class="column-search"
+ style="margin-bottom: 8px; display: flex; justify-content: flex-end">
Review Comment:
ditto
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html:
##########
@@ -25,6 +25,39 @@ <h4>Empty result set</h4>
<div
[hidden]="!currentColumns"
class="result-table">
+ <div
+ class="column-navigation"
+ style="margin-bottom: 8px; display: flex; justify-content: flex-end; gap: 8px">
Review Comment:
Can you add a scss file instead of using inline `style`?
##########
common/workflow-operator/src/main/scala/org/apache/amber/operator/source/scan/csv/CSVScanSourceOpExec.scala:
##########
@@ -92,6 +92,7 @@ class CSVScanSourceOpExec private[csv] (descString: String) extends SourceOperat
csvSetting.setMaxCharsPerColumn(-1)
csvSetting.setFormat(csvFormat)
csvSetting.setHeaderExtractionEnabled(desc.hasHeader)
+ csvSetting.setMaxColumns(10000)
Review Comment:
ditto
##########
common/workflow-operator/src/main/scala/org/apache/amber/operator/source/scan/csv/CSVScanSourceOpDesc.scala:
##########
@@ -92,6 +92,7 @@ class CSVScanSourceOpDesc extends ScanSourceOpDesc {
csvSetting.setFormat(csvFormat)
csvSetting.setHeaderExtractionEnabled(hasHeader)
csvSetting.setNullValue("")
+ csvSetting.setMaxColumns(10000)
Review Comment:
Can you make this magic number a configurable variable?
##########
common/workflow-core/src/main/scala/org/apache/amber/core/storage/result/iceberg/IcebergDocument.scala:
##########
@@ -150,8 +157,13 @@ private[storage] class IcebergDocument[T >: Null <: AnyRef](
*
* @param from start from which record inclusively, if 0 means start from the first
* @param until end at which record exclusively, if None means read to the table's EOF
+ * @param columns columns to be projected
*/
- private def getUsingFileSequenceOrder(from: Int, until: Option[Int]): Iterator[T] =
+ private def getUsingFileSequenceOrder(
+ from: Int,
+ until: Option[Int],
+ columns: Option[Seq[String]]
Review Comment:
Use a default value of `columns` to be `None` and revert all the changes you made to add `None` in the arguments.
##########
common/workflow-core/src/main/scala/org/apache/amber/core/storage/model/VirtualDocument.scala:
##########
@@ -60,6 +60,16 @@ abstract class VirtualDocument[T] extends ReadonlyVirtualDocument[T] {
def getRange(from: Int, until: Int): Iterator[T] =
throw new NotImplementedError("getRange method is not implemented")
+ /**
+ * get an iterator of a sequence starting from index `from`, until index `until`
+ * @param from the starting index (inclusive)
+ * @param until the ending index (exclusive)
+ * @param columns the columns to be projected
+ * @return an iterator that returns data items of type T
+ */
+ def getRange(from: Int, until: Int, columns: Option[Seq[String]]): Iterator[T] =
Review Comment:
You can merge two getRange() functions as a single function.
##########
common/workflow-core/src/main/scala/org/apache/amber/core/storage/result/iceberg/IcebergDocument.scala:
##########
@@ -100,20 +100,27 @@ private[storage] class IcebergDocument[T >: Null <: AnyRef](
/**
* Get an iterator for reading records from the table.
*/
- override def get(): Iterator[T] = getUsingFileSequenceOrder(0, None)
+ override def get(): Iterator[T] = getUsingFileSequenceOrder(0, None, None)
/**
* Get records within a specified range [from, until).
*/
override def getRange(from: Int, until: Int): Iterator[T] = {
- getUsingFileSequenceOrder(from, Some(until))
+ getUsingFileSequenceOrder(from, Some(until), None)
+ }
+
+ /**
+ * Get records within a specified range [from, until) with specific columns.
+ */
+ override def getRange(from: Int, until: Int, columns: Option[Seq[String]]): Iterator[T] = {
+ getUsingFileSequenceOrder(from, Some(until), columns)
Review Comment:
You can merge these functions together using default parameter.
##########
amber/src/main/scala/org/apache/texera/web/model/websocket/request/ResultPaginationRequest.scala:
##########
@@ -23,5 +23,8 @@ case class ResultPaginationRequest(
requestID: String,
operatorID: String,
pageIndex: Int,
- pageSize: Int
+ pageSize: Int,
+ columnOffset: Int = 0,
+ columnLimit: Int = Int.MaxValue,
Review Comment:
I see that the value of `columnLimit` is fixed to 25. If it's fixed this way, I don't think we even need this variable in the frontend codebase. Can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2653183890
##########
frontend/src/app/workspace/component/result-panel/result-panel.component.ts:
##########
@@ -52,7 +52,7 @@ import { CompilationState } from "../../types/workflow-compiling.interface";
import { WorkflowFatalError } from "../../types/workflow-websocket.interface";
export const DEFAULT_WIDTH = 800;
-export const DEFAULT_HEIGHT = 300;
+export const DEFAULT_HEIGHT = 500;
Review Comment:
@aglinxinyuan The issue is that the original height cuts off the numbers when opening the result panel, whereas increasing the result-panel height by 200 is the perfect size to avoid cutting off any buttons.
## Result Panel with height 300:
<img width="1107" height="522" alt="image" src="https://github.com/user-attachments/assets/7ade6919-9556-4fc8-b4d3-932245f97b50" />
## Result Panel with height 500:
<img width="1093" height="761" alt="image" src="https://github.com/user-attachments/assets/0372bc35-547b-4218-9793-ed6213872c6f" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2654286977
##########
frontend/src/app/workspace/component/result-panel/result-panel.component.ts:
##########
@@ -52,7 +52,7 @@ import { CompilationState } from "../../types/workflow-compiling.interface";
import { WorkflowFatalError } from "../../types/workflow-websocket.interface";
export const DEFAULT_WIDTH = 800;
-export const DEFAULT_HEIGHT = 300;
+export const DEFAULT_HEIGHT = 500;
Review Comment:
Ok. Let's use 500 then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2638285786
##########
common/workflow-core/src/main/scala/org/apache/texera/amber/core/storage/model/ReadonlyVirtualDocument.scala:
##########
@@ -54,7 +54,7 @@ trait ReadonlyVirtualDocument[T] {
* @param until the ending index (exclusive)
* @return an iterator that returns data items of type T
Review Comment:
add a comment to describe the parameter
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
@@ -66,6 +66,9 @@ export class ResultTableFrameComponent implements OnInit, OnChanges {
currentPageIndex: number = 1;
totalNumTuples: number = 0;
pageSize = 5;
+ currentColumnOffset = 0;
+ columnLimit = 25;
Review Comment:
Can you add a comment on why you decided to use "25" as column limit? I also whether it's better to make it a configurable parameter in `.conf` file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica merged PR #4086:
URL: https://github.com/apache/texera/pull/4086
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3582277940
@kunwp1 Please review this PR. Check if test cases are needed. I will also review it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3671396492
@chenlica @kunwp1, I addressed all the comments. Please review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2640557172
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.ts:
##########
@@ -66,6 +66,9 @@ export class ResultTableFrameComponent implements OnInit, OnChanges {
currentPageIndex: number = 1;
totalNumTuples: number = 0;
pageSize = 5;
+ currentColumnOffset = 0;
+ columnLimit = 25;
Review Comment:
I've now made it a configurable parameter
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3701069713
We can merge it after fixing the format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "chenlica (via GitHub)" <gi...@apache.org>.
chenlica commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3697967239
@Ma77Ball Please let us know after you have addressed all the comments. Then we can merge this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "aglinxinyuan (via GitHub)" <gi...@apache.org>.
aglinxinyuan commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2651933231
##########
frontend/src/app/workspace/component/result-panel/result-panel.component.ts:
##########
@@ -52,7 +52,7 @@ import { CompilationState } from "../../types/workflow-compiling.interface";
import { WorkflowFatalError } from "../../types/workflow-websocket.interface";
export const DEFAULT_WIDTH = 800;
-export const DEFAULT_HEIGHT = 300;
+export const DEFAULT_HEIGHT = 500;
Review Comment:
Can we keep the height at 300? Taking space from another component doesn’t seem like a good way to address the issue.
##########
frontend/src/app/workspace/component/result-panel/result-table-frame/result-table-frame.component.html:
##########
@@ -25,6 +25,39 @@ <h4>Empty result set</h4>
<div
[hidden]="!currentColumns"
class="result-table">
+ <div
+ class="column-search"
+ style="margin-bottom: 8px; display: flex; justify-content: flex-end">
+ <input
+ nz-input
+ placeholder="Search Columns"
+ (input)="onColumnSearch($event)"
+ style="width: 200px" />
+ </div>
+ <div
+ class="column-navigation"
+ style="margin-bottom: 8px; display: flex; justify-content: flex-end; gap: 8px">
+ <button
Review Comment:
Can we hide those two buttons when there are just a few columns? We don't need those when there are just three columns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2653183890
##########
frontend/src/app/workspace/component/result-panel/result-panel.component.ts:
##########
@@ -52,7 +52,7 @@ import { CompilationState } from "../../types/workflow-compiling.interface";
import { WorkflowFatalError } from "../../types/workflow-websocket.interface";
export const DEFAULT_WIDTH = 800;
-export const DEFAULT_HEIGHT = 300;
+export const DEFAULT_HEIGHT = 500;
Review Comment:
The issue is that the original height cuts off the numbers when opening the result panel, whereas increasing the result-panel height by 200 is the perfect size to avoid cutting off any buttons.
## Result Panel with height 300:
<img width="1107" height="522" alt="image" src="https://github.com/user-attachments/assets/7ade6919-9556-4fc8-b4d3-932245f97b50" />
## Result Panel with height 500:
<img width="1093" height="761" alt="image" src="https://github.com/user-attachments/assets/0372bc35-547b-4218-9793-ed6213872c6f" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "Ma77Ball (via GitHub)" <gi...@apache.org>.
Ma77Ball commented on PR #4086:
URL: https://github.com/apache/texera/pull/4086#issuecomment-3706317490
I already fixed the format @aglinxinyuan or @kunwp1, please approve the workflows to move forward with merging this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(ui): add pagination and search for wide-column tables [texera]
Posted by "kunwp1 (via GitHub)" <gi...@apache.org>.
kunwp1 commented on code in PR #4086:
URL: https://github.com/apache/texera/pull/4086#discussion_r2578552783
##########
amber/src/main/scala/org/apache/texera/web/model/websocket/request/ResultPaginationRequest.scala:
##########
@@ -23,5 +23,8 @@ case class ResultPaginationRequest(
requestID: String,
operatorID: String,
pageIndex: Int,
- pageSize: Int
+ pageSize: Int,
+ columnOffset: Int = 0,
+ columnLimit: Int = Int.MaxValue,
Review Comment:
I see that the value of `columnLimit` is fixed to 25. If it's fixed this way, I don't think we even need this variable in the frontend codebase. Can you check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org