[GitHub] [incubator-dolphinscheduler] lenboo commented on a change in pull request #1653: Remove @Data annotation and add @TableField annotation

[GitBox <gi...@apache.org>]

lenboo commented on a change in pull request #1653: Remove @Data annotation and add @TableField annotation
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1653#discussion_r362185658
 
 

 ##########
 File path: dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/Alert.java
 ##########
 @@ -29,96 +28,38 @@
 import java.util.HashMap;
 import java.util.Map;
 
-/**
- *  alert
- */
 @TableName("t_ds_alert")
 public class Alert {
-
-    /**
-     * id
-     */
-    @TableId(value="id", type=IdType.AUTO)
+    @TableId(value = "id", type = IdType.AUTO)
     private int id;
-
-    /**
-     * title
-     */
+    @TableField(value = "title")
     private String title;
-
-    /**
-     * show type
-     */
+    @TableField(value = "show_type")
     private ShowType showType;
-    /**
-     * content
-     */
+    @TableField(value = "content")
     private String content;
-
-    /**
-     * alert type
-     */
+    @TableField(value = "alert_type")
     private AlertType alertType;
-
-
-
-    /**
-     * alert status
-     */
+    @TableField(value = "alert_status")
 
 Review comment:
   why 'value= ',  is just @TableField("xx") would be better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services