You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/27 15:15:14 UTC
[GitHub] [pulsar] poorbarcode opened a new pull request, #16246: [fix] [broker] [fix] [broker] Consumer status is inconsistent because operations addConsumer and disconnect of PersistentSubscription compete with each other
poorbarcode opened a new pull request, #16246:
URL: https://github.com/apache/pulsar/pull/16246
### Motivation
E.g. `consumer.subscribe` and `topic.unload` executed at the same time:
| Time | `consumer.subscribe` | `topic.unload` |
| ----------- | ----------- | ----------- |
| 1 | consumer.subscribe | |
| 2 | create persistent topic | |
| 3 | create persistent subscription | |
| 4 | | topic.unload |
| 5 | | topic.close |
| 6 | persistent-subscription.addConsumer | persistent-subscription.disconnect |
| 7 | add consumer finish | Because dispathcer is empty, no consumers are closed |
| 8 | response client: success | |
| 9 | consumer.receiveMessage | |
After step 9:
- consumer considers the subscription successful
- broker considers topic unload success
But the consumer will not receive any message.
### Modifications
Make two operations `addConsumer` and `disconnect` executed sequentially.
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs, and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16246: [fix] [broker] [fix] [broker] Consumer status is inconsistent because operations addConsumer and disconnect of PersistentSubscription compete with each other
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16246:
URL: https://github.com/apache/pulsar/pull/16246#issuecomment-1167484366
@gaoran10 @Technoboy- please take a look, Thanks. ^_^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode closed pull request #16246: [fix] [broker] [fix] [broker] Consumer status is inconsistent because operations addConsumer and disconnect of PersistentSubscription compete with each other
Posted by GitBox <gi...@apache.org>.
poorbarcode closed pull request #16246: [fix] [broker] [fix] [broker] Consumer status is inconsistent because operations addConsumer and disconnect of PersistentSubscription compete with each other
URL: https://github.com/apache/pulsar/pull/16246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] poorbarcode commented on pull request #16246: [fix] [broker] [fix] [broker] Consumer status is inconsistent because operations addConsumer and disconnect of PersistentSubscription compete with each other
Posted by GitBox <gi...@apache.org>.
poorbarcode commented on PR #16246:
URL: https://github.com/apache/pulsar/pull/16246#issuecomment-1167713300
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org