[GitHub] [hudi] yanghua commented on a diff in pull request #5709: [MINOR] Print error msg when delta streamer config error happens

[GitBox <gi...@apache.org>]

yanghua commented on code in PR #5709:
URL: https://github.com/apache/hudi/pull/5709#discussion_r884142438


##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/UtilHelpers.java:
##########
@@ -122,6 +122,9 @@ public static Source createSource(String sourceClass, TypedProperties cfg, JavaS
                 HoodieDeltaStreamerMetrics.class},
             cfg, jssc, sparkSession, schemaProvider, metrics);
       } catch (HoodieException e) {
+        if (e.getCause() != null && !(e.getCause() instanceof NoSuchMethodException)) {
+          LOG.error("Could not load source class " + sourceClass, e);

Review Comment:
   I would suggest we print this error message directly. No need to add this condition `e.getCause() != null && !(e.getCause() instanceof NoSuchMethodException)`. WDYT?
   
   You just want to log more information about this exception, right? Just log it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org