You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tika.apache.org by ti...@apache.org on 2026/03/31 12:16:54 UTC

(tika) branch branch_3x updated: [TIKA-4704] close TikaInputStream to avoid leak (#2727)

This is an automated email from the ASF dual-hosted git repository.

tilman pushed a commit to branch branch_3x
in repository https://gitbox.apache.org/repos/asf/tika.git


The following commit(s) were added to refs/heads/branch_3x by this push:
     new f1b0c9452b [TIKA-4704] close TikaInputStream to avoid leak (#2727)
f1b0c9452b is described below

commit f1b0c9452bb00b45fbb7cf537bf53a328cae0258
Author: Tilman Hausherr <ti...@snafu.de>
AuthorDate: Tue Mar 31 14:16:49 2026 +0200

    [TIKA-4704] close TikaInputStream to avoid leak (#2727)
    
    * [TIKA-4704] use TemporaryResources to avoid leak
    
    * Update tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-zip-commons/src/test/java/org/apache/tika/detect/zip/ZipDetectionTest.java
    
    Co-authored-by: Copilot <17...@users.noreply.github.com>
    
    * Refactor ZipDetectionTest to simplify TikaInputStream usage
    
    * Update tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-zip-commons/src/test/java/org/apache/tika/detect/zip/ZipDetectionTest.java
    
    Co-authored-by: Copilot <17...@users.noreply.github.com>
    
    ---------
    
    Co-authored-by: Copilot <17...@users.noreply.github.com>
---
 .../src/test/java/org/apache/tika/detect/zip/ZipDetectionTest.java     | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-zip-commons/src/test/java/org/apache/tika/detect/zip/ZipDetectionTest.java b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-zip-commons/src/test/java/org/apache/tika/detect/zip/ZipDetectionTest.java
index a00bd6420b..d7ced90834 100644
--- a/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-zip-commons/src/test/java/org/apache/tika/detect/zip/ZipDetectionTest.java
+++ b/tika-parsers/tika-parsers-standard/tika-parsers-standard-modules/tika-parser-zip-commons/src/test/java/org/apache/tika/detect/zip/ZipDetectionTest.java
@@ -79,7 +79,8 @@ public class ZipDetectionTest extends TikaTest {
 
         detector = new DefaultZipContainerDetector();
         //try on a file that isn't a TikaInputStream
-        try (InputStream is = new BufferedInputStream(Files.newInputStream(TikaInputStream.get(getStream("testJAR.jar")).getPath()))) {
+        try (TikaInputStream tis = TikaInputStream.get(getStream("testJAR.jar"));
+             InputStream is = new BufferedInputStream(Files.newInputStream(tis.getPath()))) {
             assertExpected(detector, is, "application/java-archive", expectedDigest);
         }