You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by kennknowles <gi...@git.apache.org> on 2016/10/06 23:12:53 UTC

[GitHub] incubator-beam pull request #1064: [BEAM-25] Add StateSpec as a curried way ...

GitHub user kennknowles opened a pull request:

    https://github.com/apache/incubator-beam/pull/1064

    [BEAM-25] Add StateSpec as a curried way to build a StateTag

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [x] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [x] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This is an alternative to #1044, based on lessons learned there. Instead of moving the disjoint union destruction to `StateSpec` and rebuilding `StateTag` = `StateSpec` + ID I have instead written `StateSpec` = `StateTag` - ID :-)
    
    I tend to think that `StateSpec` "should" be an independent thing, but that would mean the ability to `bind` it to a state cell without providing an ID. Given current design considerations, I don't think that fits as well. So instead, this PR just embraces the fact that a `StateSpec` has no real independent meaning, but is just a curried form of `StateTag` for use in the proposed state API.
    
    I'm curious if you have a preference.
    
    R: @bjchambers AND @tgroh AND @aljoscha 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/incubator-beam StateSpec-curry

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1064.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1064
    
----
commit bc9e4b64bb68bf35e74cfb459a727b1a34655b2c
Author: Kenneth Knowles <kl...@google.com>
Date:   2016-10-06T22:46:44Z

    Add StateSpec as a curried way to build a StateTag

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1064: [BEAM-25] Add StateSpec as a curried way ...

Posted by kennknowles <gi...@git.apache.org>.
Github user kennknowles closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1064


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---