[GitHub] sijie commented on issue #1034: Servers formatted without instance id can't join a cluster with insta?

[GitBox <gi...@apache.org>]

sijie commented on issue #1034: Servers formatted without instance id can't join a cluster with insta?
URL: https://github.com/apache/bookkeeper/pull/1034#issuecomment-359902409
 
 
   @ivankelly 
   
   can you help understand this a bit more? if setup and teardown is per suite, can't you have multiple suites in one module? I don't think the docker environment is used cross suites, right?
   
   for example, if I compare [backward-compat-hierarchical-ledger-manager](https://github.com/apache/bookkeeper/blob/master/tests/backward-compat-hierarchical-ledger-manager/src/test/resources/arquillian.xml) and [backward-compat-upgrade-direct](https://github.com/apache/bookkeeper/blob/master/tests/backward-compat-upgrade-direct/src/test/resources/arquillian.xml), they are all using same [3-node-all-version-unstarted.yaml](https://github.com/apache/bookkeeper/blob/master/tests/integration-tests-topologies/src/main/resources/cube-definitions/3-node-all-version-unstarted.yaml). 
   
   Can you explain more why a new module is needed? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services