You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by prashanthvarma <gi...@git.apache.org> on 2016/11/25 10:52:12 UTC
[GitHub] cloudstack pull request #1785: CLOUDSTACK-9416 : Enabling Static NAT on an a...
GitHub user prashanthvarma opened a pull request:
https://github.com/apache/cloudstack/pull/1785
CLOUDSTACK-9416 : Enabling Static NAT on an associated Public IP to one of the NICs (networks) of a multi-NIC VM fails due to a wrong (default) Guest VM IP being selected in the GUI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/prashanthvarma/cloudstack 4.9
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1785.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1785
----
commit 094c4cf02bf75ed3e5bd227f7b4cfe614f386871
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2016-06-15T12:47:50Z
CLOUDSTACK-9416 : Enabling Static NAT on an associated Public IP to one of the NICs (networks) of a multi-NIC VM fails due to a wrong (default) Guest VM IP being selected in the GUI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1785: CLOUDSTACK-9416 : Enabling Static NAT on an a...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1785
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1785: CLOUDSTACK-9416 : Enabling Static NAT on an associat...
Posted by prashanthvarma <gi...@git.apache.org>.
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1785
@rhtyd This is a shadow of PR #1592 , rebased against 4.9 as requested.
Note: The original PR #1592 has enough LGTMs to merge this PR.
Once you merge this PR, I will close the PR #1592 .
Sorry for the inconvenience !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1785: CLOUDSTACK-9416 : Enabling Static NAT on an associat...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1785
LGTM
this PR solves the same issue as #1778
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1785: CLOUDSTACK-9416 : Enabling Static NAT on an associat...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1785
LGTM, this fixes the same issue as #1778. Since this is a pure UI change, manual testing with screenshot confirm the fix. I'll move with the merge now. The failure at Travis is not due to this change but intermittent/env issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---