[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #13222: [Improvement][api]Batch query for optimizing query process-list interface

[GitBox <gi...@apache.org>]

caishunfeng commented on code in PR #13222:
URL: https://github.com/apache/dolphinscheduler/pull/13222#discussion_r1056051757


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java:
##########
@@ -592,13 +593,12 @@ public PageInfo<ProcessDefinition> queryProcessDefinitionListPaging(@NonNull Use
         Map<Long, Schedule> scheduleMap = schedulerService.queryScheduleByProcessDefinitionCodes(processDefinitionCodes)
                 .stream()
                 .collect(Collectors.toMap(Schedule::getProcessDefinitionCode, Function.identity()));
-
+        List<UserWithProcessDefinitionCode> userWithCodes = userMapper.queryUserWithProcessDefinitionCode(
+                processDefinitionCodes);
         for (ProcessDefinition pd : processDefinitions) {
-            // todo: use batch query
-            ProcessDefinitionLog processDefinitionLog =
-                    processDefinitionLogMapper.queryByDefinitionCodeAndVersion(pd.getCode(), pd.getVersion());
-            User user = userMapper.selectById(processDefinitionLog.getOperator());
-            pd.setModifyBy(user.getUserName());
+            userWithCodes.stream()
+                    .filter(userWithCode -> userWithCode.getProcessDefinitionCode() == pd.getCode())

Review Comment:
   ```suggestion
                       .filter(userWithCode -> userWithCode.getProcessDefinitionCode() == pd.getCode() && userWithCode.getProcessDefinitionVersion() == pd.getVersion())
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org