You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/04/23 18:44:10 UTC
[GitHub] [phoenix] joshelser commented on a change in pull request #764: PHOENIX-5808 Improve shaded artifact naming convetions
joshelser commented on a change in pull request #764:
URL: https://github.com/apache/phoenix/pull/764#discussion_r414036889
##########
File path: phoenix-assembly/pom.xml
##########
@@ -42,7 +42,27 @@
<groupId>org.codehaus.mojo</groupId>
<executions>
<execution>
- <id>Symlink to deprecated client jar name</id>
+ <id>client without classifier</id>
+ <phase>compile</phase>
+ <goals>
+ <goal>exec</goal>
+ </goals>
+ <configuration>
+ <executable>ln</executable>
+ <workingDirectory></workingDirectory>
Review comment:
Should be `${project.basedir}/../phoenix-client/target`? I think this leaves it in `phoenix-assembly` and is then not reflected in the binary tarball.
```
$ ll phoenix-5.1.0-SNAPSHOT-hbase-2.2
...
-rw-r--r-- 1 jelser staff 133M Apr 23 11:47 phoenix-client-5.1.0-SNAPSHOT-hbase-2.2.jar
-rw-r--r-- 1 jelser staff 18K Apr 23 11:46 phoenix-client-5.1.0-SNAPSHOT.jar
lrwxr-xr-x 1 jelser staff 43B Apr 23 11:47 phoenix-client.jar -> phoenix-client-5.1.0-SNAPSHOT-hbase-2.2.jar
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org