You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/13 21:04:37 UTC

[GitHub] [airflow] Taragolis commented on pull request #26374: Implements SqlToSlackApiFileOperator

Taragolis commented on PR #26374:
URL: https://github.com/apache/airflow/pull/26374#issuecomment-1245952818

   > Can you explain why?
   
   1. `SqlToSlackOperator` intends to use Slack Webhook ether based on Slack App or Slack Legacy Integrations but both won't support send file, which only allowed by Slack API. Slack Incoming Webhooks and Slack API are not not interchangeable and do not have common interface.
   2. Expected different parameters, so if extend current operator than required 4-5 additional parameters which won't use in case of use send as a regular message.
   3. I thought also easier maintain something simple rather than with complicated logic and a lot of additional conditions
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org