You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by "Marc CARRE (JIRA)" <ji...@apache.org> on 2012/10/28 07:43:11 UTC
[jira] [Created] (AMQ-4140) maven-activemq-plugin does not have a
skip flag, and fails to resolve path to XBean file in multi-module builds
Marc CARRE created AMQ-4140:
-------------------------------
Summary: maven-activemq-plugin does not have a skip flag, and fails to resolve path to XBean file in multi-module builds
Key: AMQ-4140
URL: https://issues.apache.org/jira/browse/AMQ-4140
Project: ActiveMQ
Issue Type: Bug
Components: Broker
Affects Versions: 5.7.0
Environment: Windows and Linux
Reporter: Marc CARRE
Priority: Blocker
Fix For: 5.8.0
Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
Hi,
I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
I have found that:
1. path to XBean files are not resolved properly, as:
- the path is relative, and therefore, multi-module builds fail;
- at least under Windows, the generated path is not a valid URL, hence the plugin failing on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
In the attachments, I have provided:
- a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
- a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
- a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
In case you need committers, I would be happy to occasionally help.
(I noticed the documentation is rather outdated, so could help with that at least)
Cheers,
M.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (AMQ-4140) maven-activemq-plugin fails to
resolve path to XBean file in multi-module builds, and does not have a skip
flag
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487368#comment-13487368 ]
Marc Carre edited comment on AMQ-4140 at 10/30/12 11:28 PM:
------------------------------------------------------------
My apologies for not having double-checked this case earlier.
I have re-uploaded a new version tested successfully under:
- Linux
- Windows
and which passes the attached user acceptance tests, under both OS:
- multi-module build (maven-activemq-plugin-client-multimodule),
- single/simple module (maven-activemq-plugin-client-simple).
was (Author: mcarre):
My apologies for not having double-checked this case earlier.
I have re-uploaded a new version tested successfully under:
- Linux
- Windows
and which passes, under both OS:
- attached user acceptance tests in multi-module mode
- attached maven-activemq-plugin-client-simple, as a single/simple module
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4140) maven-activemq-plugin does not have a
skip flag, and fails to resolve path to XBean file in multi-module builds
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc CARRE updated AMQ-4140:
----------------------------
Description:
Hi,
I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
I have found that:
1. path to XBean files are not resolved properly, as:
- the path is relative, and therefore, multi-module builds fail;
- at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
In the attachments, I have provided:
- a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
- a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
- a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
Cheers,
M.
P.S. : In case you need committers, I would be happy to occasionally help.
(I noticed the documentation for this plugin is rather outdated, so could help with that at least)
was:
Hi,
I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
I have found that:
1. path to XBean files are not resolved properly, as:
- the path is relative, and therefore, multi-module builds fail;
- at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
In the attachments, I have provided:
- a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
- a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
- a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
Cheers,
M.
P.S. : In case you need committers, I would be happy to occasionally help.
(I noticed the documentation is rather outdated, so could help with that at least)
> maven-activemq-plugin does not have a skip flag, and fails to resolve path to XBean file in multi-module builds
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (AMQ-4140) maven-activemq-plugin fails to
resolve path to XBean file in multi-module builds, and does not have a skip
flag
Posted by "Marc Carré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487368#comment-13487368 ]
Marc Carré edited comment on AMQ-4140 at 10/30/12 11:36 PM:
------------------------------------------------------------
My apologies for not having double-checked this case earlier.
I have re-uploaded a new version tested under:
- Linux
- Windows
and which passes the unit tests and the attached user acceptance tests, under both the two OS:
- multi-module build (maven-activemq-plugin-client-multimodule),
- single/simple module (maven-activemq-plugin-client-simple).
was (Author: mcarre):
My apologies for not having double-checked this case earlier.
I have re-uploaded a new version tested under:
- Linux
- Windows
and which passes the unit tests and the attached user acceptance tests, under both the two OS:
- multi-module build (maven-activemq-plugin-client-multimodule),
- single/simple module (maven-activemq-plugin-client-simple).
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc Carré
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4140) maven-activemq-plugin does not have a
skip flag, and fails to resolve path to XBean file in multi-module builds
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc CARRE updated AMQ-4140:
----------------------------
Description:
Hi,
I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
I have found that:
1. path to XBean files are not resolved properly, as:
- the path is relative, and therefore, multi-module builds fail;
- at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
In the attachments, I have provided:
- a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
- a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
- a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
Cheers,
M.
P.S. : In case you need committers, I would be happy to occasionally help.
(I noticed the documentation is rather outdated, so could help with that at least)
was:
Hi,
I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
I have found that:
1. path to XBean files are not resolved properly, as:
- the path is relative, and therefore, multi-module builds fail;
- at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
In the attachments, I have provided:
- a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
- a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
- a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
In case you need committers, I would be happy to occasionally help.
(I noticed the documentation is rather outdated, so could help with that at least)
Cheers,
M.
> maven-activemq-plugin does not have a skip flag, and fails to resolve path to XBean file in multi-module builds
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4140) maven-activemq-plugin fails to
resolve path to XBean file in multi-module builds, and does not have a skip
flag
Posted by "Marc Carré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487761#comment-13487761 ]
Marc Carré commented on AMQ-4140:
---------------------------------
Thanks Timothy!
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc Carré
> Assignee: Timothy Bish
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4140) maven-activemq-plugin fails to resolve
path to XBean file in multi-module builds, and does not have a skip flag
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc CARRE updated AMQ-4140:
----------------------------
Summary: maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag (was: maven-activemq-plugin does not have a skip flag, and fails to resolve path to XBean file in multi-module builds)
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4140) maven-activemq-plugin does not have a
skip flag, and fails to resolve path to XBean file in multi-module builds
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc CARRE updated AMQ-4140:
----------------------------
Description:
Hi,
I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
I have found that:
1. path to XBean files are not resolved properly, as:
- the path is relative, and therefore, multi-module builds fail;
- at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
In the attachments, I have provided:
- a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
- a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
- a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
In case you need committers, I would be happy to occasionally help.
(I noticed the documentation is rather outdated, so could help with that at least)
Cheers,
M.
was:
Hi,
I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
I have found that:
1. path to XBean files are not resolved properly, as:
- the path is relative, and therefore, multi-module builds fail;
- at least under Windows, the generated path is not a valid URL, hence the plugin failing on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
In the attachments, I have provided:
- a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
- a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
- a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
In case you need committers, I would be happy to occasionally help.
(I noticed the documentation is rather outdated, so could help with that at least)
Cheers,
M.
> maven-activemq-plugin does not have a skip flag, and fails to resolve path to XBean file in multi-module builds
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation is rather outdated, so could help with that at least)
> Cheers,
> M.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AMQ-4140) maven-activemq-plugin fails to
resolve path to XBean file in multi-module builds, and does not have a skip
flag
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13486873#comment-13486873 ]
Timothy Bish commented on AMQ-4140:
-----------------------------------
Gave the patch a quick spin, the unit test fails on my Linux platform, you should try this out on a Non-Windows machine and see what other issues might exist.
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (AMQ-4140) maven-activemq-plugin fails to
resolve path to XBean file in multi-module builds, and does not have a skip
flag
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487368#comment-13487368 ]
Marc Carre edited comment on AMQ-4140 at 10/30/12 11:28 PM:
------------------------------------------------------------
My apologies for not having double-checked this case earlier.
I have re-uploaded a new version tested successfully under:
- Linux
- Windows
and which passes the attached user acceptance tests, under both the two OS:
- multi-module build (maven-activemq-plugin-client-multimodule),
- single/simple module (maven-activemq-plugin-client-simple).
was (Author: mcarre):
My apologies for not having double-checked this case earlier.
I have re-uploaded a new version tested successfully under:
- Linux
- Windows
and which passes the attached user acceptance tests, under both OS:
- multi-module build (maven-activemq-plugin-client-multimodule),
- single/simple module (maven-activemq-plugin-client-simple).
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4140) maven-activemq-plugin fails to resolve
path to XBean file in multi-module builds, and does not have a skip flag
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc CARRE updated AMQ-4140:
----------------------------
Attachment: maven-activemq-plugin.zip
maven-activemq-plugin.patch
My apologies for not having double-checked this case earlier.
I have re-uploaded a new version tested successfully under:
- Linux
- Windows
and which passes, under both OS:
- attached user acceptance tests in multi-module mode
- attached maven-activemq-plugin-client-simple, as a single/simple module
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (AMQ-4140) maven-activemq-plugin fails to resolve
path to XBean file in multi-module builds, and does not have a skip flag
Posted by "Timothy Bish (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Timothy Bish resolved AMQ-4140.
-------------------------------
Resolution: Fixed
Assignee: Timothy Bish
Patch applied with thanks.
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc Carré
> Assignee: Timothy Bish
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (AMQ-4140) maven-activemq-plugin fails to
resolve path to XBean file in multi-module builds, and does not have a skip
flag
Posted by "Marc Carré (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487368#comment-13487368 ]
Marc Carré edited comment on AMQ-4140 at 10/30/12 11:35 PM:
------------------------------------------------------------
My apologies for not having double-checked this case earlier.
I have re-uploaded a new version tested under:
- Linux
- Windows
and which passes the unit tests and the attached user acceptance tests, under both the two OS:
- multi-module build (maven-activemq-plugin-client-multimodule),
- single/simple module (maven-activemq-plugin-client-simple).
was (Author: mcarre):
My apologies for not having double-checked this case earlier.
I have re-uploaded a new version tested successfully under:
- Linux
- Windows
and which passes the attached user acceptance tests, under both the two OS:
- multi-module build (maven-activemq-plugin-client-multimodule),
- single/simple module (maven-activemq-plugin-client-simple).
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc Carré
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4140) maven-activemq-plugin fails to resolve
path to XBean file in multi-module builds, and does not have a skip flag
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc CARRE updated AMQ-4140:
----------------------------
Attachment: (was: maven-activemq-plugin.patch)
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin-user-acceptance-test.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4140) maven-activemq-plugin fails to resolve
path to XBean file in multi-module builds, and does not have a skip flag
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc CARRE updated AMQ-4140:
----------------------------
Attachment: (was: maven-activemq-plugin.zip)
> maven-activemq-plugin fails to resolve path to XBean file in multi-module builds, and does not have a skip flag
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin-user-acceptance-test.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin fails on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> I hope this will help to have this resolved in a 5.7.1 or 5.8 version of the plugin very soon? :-)
> Cheers,
> M.
> P.S. : In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation for this plugin is rather outdated, so could help with that at least)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AMQ-4140) maven-activemq-plugin does not have a
skip flag, and fails to resolve path to XBean file in multi-module builds
Posted by "Marc CARRE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AMQ-4140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Marc CARRE updated AMQ-4140:
----------------------------
Attachment: maven-activemq-plugin-user-acceptance-test.zip
maven-activemq-plugin.zip
maven-activemq-plugin.patch
> maven-activemq-plugin does not have a skip flag, and fails to resolve path to XBean file in multi-module builds
> ---------------------------------------------------------------------------------------------------------------
>
> Key: AMQ-4140
> URL: https://issues.apache.org/jira/browse/AMQ-4140
> Project: ActiveMQ
> Issue Type: Bug
> Components: Broker
> Affects Versions: 5.7.0
> Environment: Windows and Linux
> Reporter: Marc CARRE
> Priority: Blocker
> Labels: maven, patch
> Fix For: 5.8.0
>
> Attachments: maven-activemq-plugin.patch, maven-activemq-plugin-user-acceptance-test.zip, maven-activemq-plugin.zip
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> Hi,
> I am using ActiveMQ and have some integration tests leveraging the maven-activemq-plugin.
> I have found that:
> 1. path to XBean files are not resolved properly, as:
> - the path is relative, and therefore, multi-module builds fail;
> - at least under Windows, the generated path is not a valid URL, hence the plugin failing on this call: final BrokerService broker = BrokerFactory.createBroker(configUri);
> 2. unlike other Maven plugins, maven-activemq-plugin doesn't follow the convention of having a skip flag, to skip execution under some circumstances. This is not a bug, but rather an improvement that would make users' life easier IMO (and at least, mine).
> In the attachments, I have provided:
> - a multi-module build that would allow you to easily and systematically replicate the above two issues: maven-activemq-plugin-user-acceptance-test.zip
> - a "fixed" version of maven-activemq-plugin, based on trunk / 5.8-SNAPSHOT (as of 2012/10/28 06:34 BST): maven-activemq-plugin.zip
> - a patch, containing the equivalent fix, in case this format is preferred: maven-activemq-plugin.patch
> In case you need committers, I would be happy to occasionally help.
> (I noticed the documentation is rather outdated, so could help with that at least)
> Cheers,
> M.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira