You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2018/12/27 14:29:51 UTC

[GitHub] kaxil commented on a change in pull request #4324: [AIRFLOW-3327] Add support for location in BigQueryHook

kaxil commented on a change in pull request #4324: [AIRFLOW-3327] Add support for location in BigQueryHook
URL: https://github.com/apache/incubator-airflow/pull/4324#discussion_r244162990
 
 

 ##########
 File path: airflow/contrib/hooks/bigquery_hook.py
 ##########
 @@ -580,11 +587,18 @@ def run_query(self,
             by one or more columns. This is only available in combination with
             time_partitioning. The order of columns given determines the sort order.
         :type cluster_fields: list of str
+        :param location: The geographic location of the job. Required except for
+            US and EU. See details at
 
 Review comment:
   @yohei1126 Thanks for confirming, can you also try out with the changes in the PR and see if it fixes the issue for you? 
   
   Once you confirm, I will then merge it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services