[GitHub] [beam] tvalentyn commented on a diff in pull request #22503: Change _build import from setuptools to distutils

[GitBox <gi...@apache.org>]

tvalentyn commented on code in PR #22503:
URL: https://github.com/apache/beam/pull/22503#discussion_r932727199


##########
sdks/python/apache_beam/examples/complete/juliaset/setup.py:
##########
@@ -30,7 +30,8 @@
 import subprocess
 
 import setuptools
-from setuptools.command.build import build as _build  # type: ignore
+
+from distutils.command.build import build as _build  # isort:skip

Review Comment:
   Add comments why this is has to be skipped so that somebody doesn't try to clean it up.



##########
sdks/python/apache_beam/examples/complete/juliaset/setup.py:
##########
@@ -30,7 +30,8 @@
 import subprocess
 
 import setuptools
-from setuptools.command.build import build as _build  # type: ignore
+
+from distutils.command.build import build as _build  # isort:skip

Review Comment:
   Add comments why this isort has to be skipped so that somebody doesn't try to clean it up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org