You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by vj...@apache.org on 2024/12/12 20:43:17 UTC
(hbase) branch branch-2.6 updated: HBASE-28959 Output fsreadtime in SlowLogPayLoad to hbase:slowlog (#6502)
This is an automated email from the ASF dual-hosted git repository.
vjasani pushed a commit to branch branch-2.6
in repository https://gitbox.apache.org/repos/asf/hbase.git
The following commit(s) were added to refs/heads/branch-2.6 by this push:
new b8787f9b31f HBASE-28959 Output fsreadtime in SlowLogPayLoad to hbase:slowlog (#6502)
b8787f9b31f is described below
commit b8787f9b31f158ef655fcb0beba706cf5f5732e9
Author: weixiao <le...@gmail.com>
AuthorDate: Fri Dec 13 04:40:13 2024 +0800
HBASE-28959 Output fsreadtime in SlowLogPayLoad to hbase:slowlog (#6502)
Signed-off-by: Ray Mattingly <rm...@apache.org>
Signed-off-by: Viraj Jasani <vj...@apache.org>
---
.../org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java | 2 ++
.../resources/hbase-webapps/regionserver/rsOperationDetails.jsp | 8 ++++++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
index 6a45c0ffa88..c74cd3aad66 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/slowlog/SlowLogTableAccessor.java
@@ -83,6 +83,8 @@ public class SlowLogTableAccessor {
Bytes.toBytes(Integer.toString(slowLogPayload.getProcessingTime())))
.addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("queue_time"),
Bytes.toBytes(Integer.toString(slowLogPayload.getQueueTime())))
+ .addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("fs_read_time"),
+ Bytes.toBytes(Long.toString(slowLogPayload.getFsReadTime())))
.addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("region_name"),
Bytes.toBytes(slowLogPayload.getRegionName()))
.addColumn(HConstants.SLOWLOG_INFO_FAMILY, Bytes.toBytes("response_size"),
diff --git a/hbase-server/src/main/resources/hbase-webapps/regionserver/rsOperationDetails.jsp b/hbase-server/src/main/resources/hbase-webapps/regionserver/rsOperationDetails.jsp
index e8944b63f43..abdab7df7d6 100644
--- a/hbase-server/src/main/resources/hbase-webapps/regionserver/rsOperationDetails.jsp
+++ b/hbase-server/src/main/resources/hbase-webapps/regionserver/rsOperationDetails.jsp
@@ -97,6 +97,7 @@
<th>Start Time</th>
<th>Processing Time</th>
<th>Queue Time</th>
+ <th>FsRead Time</th>
<th>Response Size</th>
<th>Block Bytes Scanned</th>
<th>Client Address</th>
@@ -118,8 +119,9 @@
<td><%=new Date(r.getStartTime() + 1800*1000)%></td>
<td><%=r.getProcessingTime()%>ms</td>
<td><%=r.getQueueTime()%>ms</td>
+ <td><%=r.getFsReadTime()%>ms</td>
<td><%=StringUtils.byteDesc(r.getResponseSize())%></td>
- <td><%=StringUtils.byteDesc(r.getBlockBytesScanned())%></td>
+ <td><%=StringUtils.byteDesc(r.getBlockBytesScanned())%></td>
<td><%=r.getClientAddress()%></td>
<td><%=r.getServerClass()%></td>
<td><%=r.getMethodName()%></td>
@@ -144,6 +146,7 @@
<th>Start Time</th>
<th>Processing Time</th>
<th>Queue Time</th>
+ <th>FsRead Time</th>
<th>Response Size</th>
<th>Block Bytes Scanned</th>
<th>Client Address</th>
@@ -165,8 +168,9 @@
<td><%=new Date(r.getStartTime() + 1800*1000)%></td>
<td><%=r.getProcessingTime()%>ms</td>
<td><%=r.getQueueTime()%>ms</td>
+ <td><%=r.getFsReadTime()%>ms</td>
<td><%=StringUtils.byteDesc(r.getResponseSize())%></td>
- <td><%=StringUtils.byteDesc(r.getBlockBytesScanned())%></td>
+ <td><%=StringUtils.byteDesc(r.getBlockBytesScanned())%></td>
<td><%=r.getClientAddress()%></td>
<td><%=r.getServerClass()%></td>
<td><%=r.getMethodName()%></td>