You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by lvfangmin <gi...@git.apache.org> on 2017/08/30 18:49:30 UTC
[GitHub] zookeeper pull request #353: [ZOOKEEPER-2886] Permanent session moved error ...
GitHub user lvfangmin opened a pull request:
https://github.com/apache/zookeeper/pull/353
[ZOOKEEPER-2886] Permanent session moved error in multi-op only conne…
…ctions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lvfangmin/zookeeper ZOOKEEPER-2886
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/353.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #353
----
commit 8720bb2fcb310edab49ecfebab9c8ba593087717
Author: Fangmin Lyu <al...@fb.com>
Date: 2017-08-30T18:48:59Z
[ZOOKEEPER-2886] Permanent session moved error in multi-op only connections
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...
Posted by lvfangmin <gi...@git.apache.org>.
Github user lvfangmin commented on the issue:
https://github.com/apache/zookeeper/pull/353
@anmolnar thanks for reviewing, the testNoLogBeforeLeaderEstablishment was introduced by mistake during rebase, and for the confusion. I've fixed the other test to catch the issue I'm trying to reproduce by removing the zk.dontReconnect() statement.
Here is the problem I'm trying to address in this diff:
1. client trying to renew session A on server S1
2. S1 is slow (like full GC, or high network delay due to packet lost) on sending the revalidate request to leader
3. client timed out on renew session A on server S1, and tried to connect to S2
4. S2 is faster than S1, and it revalidated the session on leader and owns the session
5. S1's revalidate finally reached leader, and leader updated the owner to S1
6. from now on, the requests from this client will always get session moved error, although S2 is the right one which owns the session
The server need to close session in this case to allow the client to reconnect and address this corner case.
Jira ZOOKEEPER-710 solved the non multi-op cases, but if the client only sends multi-op it can hit this problem again, which is addressed in this diff.
---
[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/353
@phunt Would you like to take a quick look?
You worked on the patch for ZOOKEEPER-710.
---
[GitHub] zookeeper pull request #353: [ZOOKEEPER-2886] Permanent session moved error ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/353
---
[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...
Posted by breed <gi...@git.apache.org>.
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/353
quick question, is it ok that the voting happens here rather than the jira? i thought comments would be bridged over, but that doesn't seem to be happening...
---
[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...
Posted by hanm <gi...@git.apache.org>.
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/353
@breed it's ok to vote here and the comments are bridged over to JIRA. In this case, check https://issues.apache.org/jira/browse/ZOOKEEPER-2886. Note you need to select the "Work Log" tab instead of the default "Comments" tab to see comments made in github. It's a change made recently to avoid github comments spamming JIRA comments. See https://www.mail-archive.com/dev@zookeeper.apache.org/msg57662.html for the history.
---
[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...
Posted by breed <gi...@git.apache.org>.
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/353
+1
thanx @lvfangmin ! this looks good to me. are you okay with this @anmolnar ?
---
[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...
Posted by breed <gi...@git.apache.org>.
Github user breed commented on the issue:
https://github.com/apache/zookeeper/pull/353
ok, with two +1s i'll be committing this one.
---
[GitHub] zookeeper issue #353: [ZOOKEEPER-2886] Permanent session moved error in mult...
Posted by anmolnar <gi...@git.apache.org>.
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/353
@breed sure, go ahead please
---