You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@subversion.apache.org by st...@apache.org on 2012/09/04 17:50:11 UTC

svn commit: r1380695 - /subversion/trunk/subversion/libsvn_subr/simple_providers.c

Author: stsp
Date: Tue Sep  4 15:50:11 2012
New Revision: 1380695

URL: http://svn.apache.org/viewvc?rev=1380695&view=rev
Log:
* subversion/libsvn_subr/simple_providers.c
  (svn_auth__simple_creds_cache_set): Don't claim creds were saved if
   svn_config_write_auth_data() returns an error. Not sure why we don't
   just return an error in this case, so add a ### comment.

Modified:
    subversion/trunk/subversion/libsvn_subr/simple_providers.c

Modified: subversion/trunk/subversion/libsvn_subr/simple_providers.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/simple_providers.c?rev=1380695&r1=1380694&r2=1380695&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_subr/simple_providers.c (original)
+++ subversion/trunk/subversion/libsvn_subr/simple_providers.c Tue Sep  4 15:50:11 2012
@@ -475,6 +475,10 @@ svn_auth__simple_creds_cache_set(svn_boo
   /* Save credentials to disk. */
   err = svn_config_write_auth_data(creds_hash, SVN_AUTH_CRED_SIMPLE,
                                    realmstring, config_dir, pool);
+  if (err)
+    *saved = FALSE;
+
+  /* ### return error? */
   svn_error_clear(err);
 
   return SVN_NO_ERROR;