You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/05 06:47:04 UTC

[GitHub] [flink] twalthr commented on a change in pull request #8984: [FLINK-13088][table-api] Support lazy query transformation & execution on TableEnvironment

twalthr commented on a change in pull request #8984:  [FLINK-13088][table-api] Support lazy query transformation & execution on TableEnvironment
URL: https://github.com/apache/flink/pull/8984#discussion_r300555474
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
 ##########
 @@ -266,31 +264,24 @@ public Table sqlQuery(String query) {
 	}
 
 	@Override
-	public void sqlUpdate(String stmt) {
-		sqlUpdate(stmt, new StreamQueryConfig());
-	}
-
-	@Override
-	public void insertInto(Table table, QueryConfig queryConfig, String path, String... pathContinued) {
+	public void insertInto(Table table, String path, String... pathContinued) {
 		List<String> fullPath = new ArrayList<>(Arrays.asList(pathContinued));
 		fullPath.add(0, path);
 
-		queryConfigProvider.setConfig((StreamQueryConfig) queryConfig);
-		List<Transformation<?>> translate = planner.translate(Collections.singletonList(
+		List<ModifyOperation> modifyOperations = Collections.singletonList(
 			new CatalogSinkModifyOperation(
 				fullPath,
-				table.getQueryOperation())));
-
-		execEnv.apply(translate);
-	}
+				table.getQueryOperation()));
 
-	@Override
-	public void insertInto(Table table, String path, String... pathContinued) {
-		insertInto(table, new StreamQueryConfig(), path, pathContinued);
+		if (shouldTranslateEagerly()) {
 
 Review comment:
   nit: can we give those methods better names? `isEagerOperationTranslation`, `translateOperation`, `bufferOperation`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services