You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2023/01/04 14:03:56 UTC

[GitHub] [commons-csv] garydgregory commented on a diff in pull request #295: Add support for trailing text after the closing quote, for Excel compatibility

garydgregory commented on code in PR #295:
URL: https://github.com/apache/commons-csv/pull/295#discussion_r1061513167


##########
src/test/java/org/apache/commons/csv/LexerTest.java:
##########
@@ -431,4 +431,14 @@ public void testTrimTrailingSpacesZeroLength() throws Exception {
         lexer.trimTrailingSpaces(buffer);
         assertThat(lexer.nextToken(new Token()), matches(EOF, ""));
     }
+
+    @Test
+    public void testTrailingTextAfterQuote() throws Exception {

Review Comment:
   Add a test asserting the expected behavior when if the new toggle is `false`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org