You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by is...@apache.org on 2017/05/25 12:17:36 UTC
lucene-solr:master: SOLR-10004: Adding descriptions for a few classes
to assess impact on smoke tester warnings
Repository: lucene-solr
Updated Branches:
refs/heads/master effd3766e -> 6d80320ae
SOLR-10004: Adding descriptions for a few classes to assess impact on smoke tester warnings
Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/6d80320a
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/6d80320a
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/6d80320a
Branch: refs/heads/master
Commit: 6d80320aef9b1bdcbe5a9bba153af5adc45f84aa
Parents: effd376
Author: Ishan Chattopadhyaya <is...@apache.org>
Authored: Thu May 25 17:43:45 2017 +0530
Committer: Ishan Chattopadhyaya <is...@apache.org>
Committed: Thu May 25 17:47:21 2017 +0530
----------------------------------------------------------------------
solr/core/src/java/org/apache/solr/update/PeerSync.java | 6 +++++-
.../java/org/apache/solr/update/SolrCmdDistributor.java | 4 +++-
solr/core/src/java/org/apache/solr/update/UpdateLog.java | 11 +++++++++--
3 files changed, 17 insertions(+), 4 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/6d80320a/solr/core/src/java/org/apache/solr/update/PeerSync.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/update/PeerSync.java b/solr/core/src/java/org/apache/solr/update/PeerSync.java
index dfadb0c..c6bfbbf 100644
--- a/solr/core/src/java/org/apache/solr/update/PeerSync.java
+++ b/solr/core/src/java/org/apache/solr/update/PeerSync.java
@@ -65,7 +65,11 @@ import static org.apache.solr.common.params.CommonParams.ID;
import static org.apache.solr.update.processor.DistributedUpdateProcessor.DistribPhase.FROMLEADER;
import static org.apache.solr.update.processor.DistributingUpdateProcessorFactory.DISTRIB_UPDATE_PARAM;
-/** @lucene.experimental */
+/**
+ * @lucene.experimental
+ * This class is useful for performing peer to peer synchronization of recently indexed update commands during
+ * recovery process.
+ */
public class PeerSync implements SolrMetricProducer {
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
private boolean debug = log.isDebugEnabled();
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/6d80320a/solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java b/solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java
index dac4000..5772b2e 100644
--- a/solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java
+++ b/solr/core/src/java/org/apache/solr/update/SolrCmdDistributor.java
@@ -51,7 +51,9 @@ import java.util.concurrent.ExecutorCompletionService;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Future;
-
+/**
+ * Used for distributing commands from a shard leader to its replicas.
+ */
public class SolrCmdDistributor implements Closeable {
private static final int MAX_RETRIES_ON_FORWARD = 25;
private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/6d80320a/solr/core/src/java/org/apache/solr/update/UpdateLog.java
----------------------------------------------------------------------
diff --git a/solr/core/src/java/org/apache/solr/update/UpdateLog.java b/solr/core/src/java/org/apache/solr/update/UpdateLog.java
index 87b93f4..4928aa1 100644
--- a/solr/core/src/java/org/apache/solr/update/UpdateLog.java
+++ b/solr/core/src/java/org/apache/solr/update/UpdateLog.java
@@ -80,7 +80,11 @@ import static org.apache.solr.update.processor.DistributedUpdateProcessor.Distri
import static org.apache.solr.update.processor.DistributingUpdateProcessorFactory.DISTRIB_UPDATE_PARAM;
-/** @lucene.experimental */
+/**
+ * @lucene.experimental
+ * This holds references to the transaction logs and pointers for the document IDs to their
+ * exact positions in the transaction logs.
+ */
public class UpdateLog implements PluginInfoInitialized, SolrMetricProducer {
private static final long STATUS_TIME = TimeUnit.NANOSECONDS.convert(60, TimeUnit.SECONDS);
public static String LOG_FILENAME_PATTERN = "%s.%019d";
@@ -143,7 +147,7 @@ public class UpdateLog implements PluginInfoInitialized, SolrMetricProducer {
/**
* The index of the _version_ value in an entry from the transaction log.
*/
-public static final int VERSION_IDX = 1;
+ public static final int VERSION_IDX = 1;
/**
* The index of the previous pointer in an entry from the transaction log.
@@ -204,6 +208,9 @@ public static final int VERSION_IDX = 1;
}
};
+ /**
+ * Holds the query and the version for a DeleteByQuery command
+ */
public static class DBQ {
public String q; // the query string
public long version; // positive version of the DBQ