Re: Review Request 30250: LENS-186: notify session lifecycle events

[Rajat Khandelwal <ra...@gmail.com>]

> On Jan. 27, 2015, 5:08 a.m., Jaideep dhok wrote:
> >

`SessionExpired extends SessionClosed`, then any handler on `SessionClosed` will be applied in both cases. This design additionaly allows us to do separate/additional handling for `SessionExpired` events. An even more generic way would be to keep three classes: `SessionEnded`, `SessionExpired`, `SessionClosed` where the latter two extend from the first.


- Rajat


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30250/#review69749
-----------------------------------------------------------


On Jan. 25, 2015, 8:56 a.m., Raju Bairishetti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30250/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2015, 8:56 a.m.)
> 
> 
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
> 
> 
> Bugs: LENS-186
>     https://issues.apache.org/jira/browse/LENS-186
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> If a service is maintaining some session specific data events like session started or session closed would be useful for init/cleanup of resources.
> 
> This would be also useful in maintaining session history.
> 
> 
> Diffs
> -----
> 
>   lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionClosed.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionEvent.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionExpired.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionOpened.java PRE-CREATION 
>   lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionRestored.java PRE-CREATION 
>   lens-server/src/main/java/org/apache/lens/server/LensService.java 7756236 
>   lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java c95a948 
>   lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7641232 
>   lens-server/src/test/java/org/apache/lens/server/query/TestEventService.java 0db5c02 
> 
> Diff: https://reviews.apache.org/r/30250/diff/
> 
> 
> Testing
> -------
> 
> Added a unit test in TestEventService
> 
> 
> Thanks,
> 
> Raju Bairishetti
> 
>