You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/05/19 05:23:04 UTC

[GitHub] [tvm] vvchernov commented on a diff in pull request #11358: WIP: [Virtual Machine] Implementation of 'set_output_zero_copy'

vvchernov commented on code in PR #11358:
URL: https://github.com/apache/tvm/pull/11358#discussion_r876604094


##########
src/runtime/vm/vm.cc:
##########
@@ -537,7 +631,7 @@ void VirtualMachine::RunLoop() {
         from_obj = ReadRegister(instr.from);
         WriteRegister(instr.dst, from_obj);
         pc_++;
-        goto main_loop;
+        break;

Review Comment:
   Thanks! I always think that simple loop is better than jump approach, it can be checked further. Just now I'm aware about the feature design.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org