You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/02/09 14:49:16 UTC

[GitHub] ffinfo edited a comment on issue #4396: [WIP][AIRFLOW-3585] - Add edges to database

ffinfo edited a comment on issue #4396: [WIP][AIRFLOW-3585] - Add edges to database
URL: https://github.com/apache/airflow/pull/4396#issuecomment-462050160
 
 
   @feng-tao @ashb @Fokko I managed to implement the versioned graphs.
   Because I now actively use DagModel during create_dagrun this did require that the DagModel is always in the database during testing (this was not always the case). Because of this I touched a lot of test code, like dag.sync_to_db().
   After this I needed to resolve some statefull tests, I manage to do this by adding some delete statements to the database during the tests.
   
   Only now just 1 single test is failing and I can't see why this is happening. This test that is failing on travis is: `test_models.TaskInstanceTest.test_email_alert`
   On my local machine this test runs fine.
   <img width="587" alt="screenshot 2019-02-09 at 15 44 13" src="https://user-images.githubusercontent.com/2419555/52522143-91cc4f00-2c81-11e9-8cb4-9baf121af231.png">
   
   Anyone can see why this is happening?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services