[GitHub] gatorsmile commented on a change in pull request #23552: [DO-NOT-MERGE][SPARK-23710] Upgrade built-in Hive to 2.3.4(Without hive-thriftserver)

[GitBox <gi...@apache.org>]

gatorsmile commented on a change in pull request #23552: [DO-NOT-MERGE][SPARK-23710] Upgrade built-in Hive to 2.3.4(Without hive-thriftserver)
URL: https://github.com/apache/spark/pull/23552#discussion_r248015481
 
 

 ##########
 File path: sql/hive/src/main/scala/org/apache/spark/sql/hive/client/IsolatedClientLoader.scala
 ##########
 @@ -192,6 +192,7 @@ private[hive] class IsolatedClientLoader(
     (name.startsWith("com.google") && !name.startsWith("com.google.cloud")) ||
     name.startsWith("java.lang.") ||
     name.startsWith("java.net") ||
+    name.startsWith("org.apache.derby.") ||
 
 Review comment:
   This breaks Livy, as @HyukjinKwon pointed out. https://github.com/apache/spark/pull/20944#issuecomment-436530497

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org