You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/06/25 15:46:01 UTC
[jira] [Commented] (IMPALA-3675) consider turning -Werror on for
release and address sanitizer builds
[ https://issues.apache.org/jira/browse/IMPALA-3675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872453#comment-16872453 ]
ASF subversion and git services commented on IMPALA-3675:
---------------------------------------------------------
Commit efe751078f8ab674523ccfe15be50349332b16bf in impala's branch refs/heads/2.x from Tim Armstrong
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=efe7510 ]
IMPALA-3675: part 1: -Werror for ASAN
This fixes some clang warnings and enables -Werror going forward for
ASAN.
It adds -Wno-return-type-c-linkage to suppress a warning that otherwise
would fail the build.
It also enables the mismatched tags check and fixes the various
instances of it (this warning is irritating for YouCompleteMe users).
Change-Id: If83ca41cde49fd6cfde479e45f9cfdd9e3a45bec
Reviewed-on: http://gerrit.cloudera.org:8080/11002
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> consider turning -Werror on for release and address sanitizer builds
> --------------------------------------------------------------------
>
> Key: IMPALA-3675
> URL: https://issues.apache.org/jira/browse/IMPALA-3675
> Project: IMPALA
> Issue Type: Improvement
> Components: Backend
> Affects Versions: Impala 2.6.0
> Reporter: Silvius Rus
> Priority: Minor
> Labels: newbie, static-analysis
>
> Currently it seems we're only using -Werror with debug builds.
> The problem is that a number of GCC warnings get issued by the analysis/transformation at -O2 or higher. So there could be warnings in our release builds that we're simply ignoring.
> We should consider turning -Werror on in release builds. Perhaps have another "static-analysis" target that does something like this (and use it in GVMs and recommend before submitting code reviews):
> {code}
> g++ ${CXX_FLAGS_RELEASE} -fsyntax-only -Werror -Wfatal-errors ...
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org