You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/08/11 09:19:18 UTC
[GitHub] [incubator-linkis] leeebai opened a new pull request, #2699: clear expired cookie when user login
leeebai opened a new pull request, #2699:
URL: https://github.com/apache/incubator-linkis/pull/2699
<!--
Thank you for sending the PR! We appreciate you spending the time to work on these changes.
You can learn more about contributing to Apache Linkis here: https://linkis.apache.org/community/how-to-contribute
Happy contributing!
-->
### What is the purpose of the change
When the domain name of linkis gateway is switched, the logged in users will fail to authenticate most of the interfaces because they hold cookies of expired domain names.
Whenever the linkis login interface is called, the cookies in the linkis login state under all levels of domain names are cleared.
### Related issues/PRs
Related issues: #2695
### Checklist
- [✔] I have read the [Contributing Guidelines on pull requests](https://github.com/facebook/docusaurus/blob/main/CONTRIBUTING.md#pull-requests).
- [✔ ] I have explained the need for this PR and the problem it solves
- [✔ ] I have explained the changes or the new features added to this PR
- [✔ ] I have added tests corresponding to this change
- [✔] I have updated the documentation to reflect this change
- [✔ ] I have verified that this change is backward compatible (If not, please discuss on the [Linkis mailing list](https://linkis.apache.org/community/how-to-subscribe) first)
- [✔ ] **If this is a code change**: I have written unit tests to fully verify the new behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2699: clear expired cookie when user login
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2699:
URL: https://github.com/apache/incubator-linkis/pull/2699#issuecomment-1211764067
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2699?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2699](https://codecov.io/gh/apache/incubator-linkis/pull/2699?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bda2ddb) into [dev-1.3.0](https://codecov.io/gh/apache/incubator-linkis/commit/d753cd8081c10edbd39b66b53aeafc42eb42960a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d753cd8) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## dev-1.3.0 #2699 +/- ##
===============================================
+ Coverage 14.75% 14.76% +0.01%
- Complexity 1161 1163 +2
===============================================
Files 740 740
Lines 23172 23172
Branches 3429 3429
===============================================
+ Hits 3418 3422 +4
+ Misses 19289 19286 -3
+ Partials 465 464 -1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2699?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/linkis/scheduler/queue/LoopArrayQueue.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2699/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvTG9vcEFycmF5UXVldWUuc2NhbGE=) | `33.96% <0.00%> (+1.88%)` | :arrow_up: |
| [...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2699/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvZmlmb3F1ZXVlL0ZJRk9Vc2VyQ29uc3VtZXIuc2NhbGE=) | `37.77% <0.00%> (+2.22%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #2699: clear expired cookie when user login
Posted by GitBox <gi...@apache.org>.
casionone merged PR #2699:
URL: https://github.com/apache/incubator-linkis/pull/2699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org