Re: [PATCH] #4OS400/EBCDIC Port: Disable svn:executable automatic setting.

[Julian Foad <ju...@btopenworld.com>]

Paul Burba wrote:
> [[[
> OS400/EBCDIC Port: Disable svn:executable automatic property setting.
> 
> This is the <nth> of several patches to allow Subversion to run

Just say "one of several".

> on IBM's OS400 V5R4.
> 
> The OS400's IFS (Integrated File System) supports unix-like file
> permissions.  However, the executable permission has no real meaning
> on the iSeries.  This becomes a problem because when creating or

Spurious "because" (it comes later).

> copying a file to the IFS via a mapped Windows drive or with the IBM
> Rational Software Development Platform (two common practices) because
> in these cases the resulting files have permissions set at -rwxrwxrwx
> by default.  To avoid svn:executable getting set on every svn add(ed)
> file this patch turns off that automatic property setting. 

OK, that approach seems reasonable.

> 
> * subversion/libsvn_client/add.c
>    (svn_client__get_auto_props): Don't automatically set 
>     svn:executable property on added files.
> ]]]

> Index: subversion/libsvn_client/add.c
> ===================================================================
> --- subversion/libsvn_client/add.c	(revision 18468)
> +++ subversion/libsvn_client/add.c	(working copy)
> @@ -1,4 +1,4 @@
> -/*
> +	/*

Huh?

>   * add.c:  wrappers around wc add/mkdir functionality.
>   *
>   * ====================================================================
> @@ -182,6 +182,10 @@
>                        svn_string_create (autoprops.mimetype, pool));
>      }
>  
> +  /* Don't automatically set the svn:executable property on added items
> +   * on OS400.  While OS400 supports the executable permission its use is
> +   * inconsistent at best. */
> +#ifndef AS400
>    /* if executable has not been set check the file */
>    if (! autoprops.have_executable)
>      {
> @@ -192,6 +196,7 @@
>                        strlen (SVN_PROP_EXECUTABLE), 
>                        svn_string_create ("", pool));
>      }
> +#endif
>  
>    *mimetype = autoprops.mimetype;
>    return SVN_NO_ERROR;

OK, +1.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org