You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/31 20:49:07 UTC

[GitHub] [arrow-datafusion] avantgardnerio commented on a diff in pull request #3311: Custom table provider factories

avantgardnerio commented on code in PR #3311:
URL: https://github.com/apache/arrow-datafusion/pull/3311#discussion_r960013451


##########
datafusion/sql/src/parser.rs:
##########
@@ -41,10 +41,7 @@ fn parse_file_type(s: &str) -> Result<FileType, ParserError> {
         "NDJSON" => Ok(FileType::NdJson),
         "CSV" => Ok(FileType::CSV),
         "AVRO" => Ok(FileType::Avro),
-        other => Err(ParserError::ParserError(format!(
-            "expect one of PARQUET, AVRO, NDJSON, or CSV, found: {}",
-            other
-        ))),
+        name => Ok(FileType::Custom(name.to_string()))

Review Comment:
   Eventually I'd like to un-hard-code the built-in tables and just have a `ListingTableFactory` in the map so all these behave the same.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org