You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/17 17:04:54 UTC

[kudu-CR] [java] Fix TestKuduPartitioner errorprone warning 

Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14488


Change subject: [java] Fix TestKuduPartitioner errorprone warning
......................................................................

[java] Fix TestKuduPartitioner errorprone warning

This fixes the following errorprone warning:

Expression of type int may overflow before being assigned to a long
long upperBound = timeoutMs * 2; // Add 100% to avoid flakiness.

Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/14488/1
-- 
To view, visit http://gerrit.cloudera.org:8080/14488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
Gerrit-Change-Number: 14488
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>

[kudu-CR] [java] Fix TestKuduPartitioner errorprone warning

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14488 )

Change subject: [java] Fix TestKuduPartitioner errorprone warning
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/14488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
Gerrit-Change-Number: 14488
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 18:36:53 +0000
Gerrit-HasComments: No

[kudu-CR] [java] Fix TestKuduPartitioner errorprone warning

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14488 )

Change subject: [java] Fix TestKuduPartitioner errorprone warning
......................................................................

[java] Fix TestKuduPartitioner errorprone warning

This fixes the following errorprone warning:

Expression of type int may overflow before being assigned to a long
long upperBound = timeoutMs * 2; // Add 100% to avoid flakiness.

Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
Reviewed-on: http://gerrit.cloudera.org:8080/14488
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduPartitioner.java
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kudu Jenkins: Verified
  Adar Dembo: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/14488
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9fd41b7cae9502468728efbdf51e3d7191447371
Gerrit-Change-Number: 14488
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)