[jira] [Work logged] (AMQ-8550) ActiveMQSslConnectionFactory: Allow for SSL Truststore w/o password (Nullpointer Exception) Fix inside

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AMQ-8550?focusedWorklogId=752977&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-752977 ]

ASF GitHub Bot logged work on AMQ-8550:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Apr/22 16:20
            Start Date: 05/Apr/22 16:20
    Worklog Time Spent: 10m 
      Work Description: cshannon opened a new pull request, #812:
URL: https://github.com/apache/activemq/pull/812

   Inside ActiveMQSslConnectionFactory the passwords should be checked for
   null so a NPE isn't thrown. Null will be passed to the factories instead
   and the keystore/truststore factories will try and load the keystores
   using null for the password which may or may not work depending on the
   implementation and if password is set.




Issue Time Tracking
-------------------

            Worklog Id:     (was: 752977)
    Remaining Estimate: 0h
            Time Spent: 10m

> ActiveMQSslConnectionFactory: Allow for SSL Truststore w/o password (Nullpointer Exception) Fix inside
> ------------------------------------------------------------------------------------------------------
>
>                 Key: AMQ-8550
>                 URL: https://issues.apache.org/jira/browse/AMQ-8550
>             Project: ActiveMQ
>          Issue Type: Bug
>          Components: JMS client
>            Reporter: Andreas Gorges
>            Assignee: Christopher L. Shannon
>            Priority: Major
>             Fix For: 5.17.1
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When you assign a Truststore without a password the method {color:#000000}ActiveMQSslConnectionFactory.{color}{color:#00627a}createTrustManager throws a NullPointer exception in Line 135:
> {color}
>  
> {code:java}
> trustedCertStore.load(tsStream, trustStorePassword.toCharArray()); {code}
>  
> {color:#00627a}Please change the code to:{color}
> {code:java}
> char[] password = null;
> if (trustStorePassword != null) {
>      password = trustStorePassword.toCharArray();
> }
> trustedCertStore.load(tsStream, password);
>   {code}
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)