You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2019/05/08 17:00:59 UTC

[GitHub] [incubator-openwhisk] jthomas commented on a change in pull request #4472: Updating runtimes to include new Node.js v12 image.

jthomas commented on a change in pull request #4472: Updating runtimes to include new Node.js v12 image.
URL: https://github.com/apache/incubator-openwhisk/pull/4472#discussion_r282158614
 
 

 ##########
 File path: docs/actions-nodejs.md
 ##########
 @@ -43,7 +43,7 @@ and demonstrate how to bundle multiple JavaScript files and third party dependen
 
   The CLI automatically infers the type of the action by using the source file extension.
   For `.js` source files, the action runs by using a Node.js runtime. You may specify
-  the Node.js runtime to use by explicitly specifying the parameter `--kind nodejs:10`, `--kind nodejs:8`, or `--kind nodejs:6`
+  the Node.js runtime to use by explicitly specifying the parameter `--kind nodejs:12`, `--kind nodejs:10`, `--kind nodejs:8`, or `--kind nodejs:6`
 
 Review comment:
   I'm not sure about this. It is still available in the project (for back compat reasons atm). Until it's removed - which is another PR, I think we should keep it in the docs? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services