You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Nils-Helge Garli (JIRA)" <ji...@apache.org> on 2007/08/11 14:55:20 UTC

[jira] Created: (WW-2104) Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack

Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack
----------------------------------------------------------------------------------------------

                 Key: WW-2104
                 URL: https://issues.apache.org/struts/browse/WW-2104
             Project: Struts 2
          Issue Type: Bug
          Components: Portlet Integration
            Reporter: Nils-Helge Garli
            Assignee: Nils-Helge Garli
             Fix For: Future


Since there is no wrapping of the render request when dispatching to the JSPs, request attributes will not be resolved from the value stack, and tags such as displaytag won't work unless objects are explicitly put on the request as an attribute.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2104) Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41801 ] 

James Holmes commented on WW-2104:
----------------------------------

Many thanks for opening the ticket and putting together the initial code! I am testing it now and it is working for me. The Displaytag library is now picking up objects on the valuestack.

One thing I noticed though is that you have to define the DispatcherServlet in web.xml using the specific name "dispatcherServlet". I'm wondering if there is a way to make this dynamic. By that I mean that you can use any name for the servlet and the Struts 2 portlet code will automatically find the servlet. If not, I propose we make the name be something like "Struts2PortletDispatcherServlet" that is more descriptive and less likely to have any name conflict with another servlet someone might have.

> Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack
> ----------------------------------------------------------------------------------------------
>
>                 Key: WW-2104
>                 URL: https://issues.apache.org/struts/browse/WW-2104
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Portlet Integration
>            Reporter: Nils-Helge Garli
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.0
>
>
> Since there is no wrapping of the render request when dispatching to the JSPs, request attributes will not be resolved from the value stack, and tags such as displaytag won't work unless objects are explicitly put on the request as an attribute.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-2104) Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Nils-Helge Garli resolved WW-2104.
----------------------------------

    Resolution: Fixed

> Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack
> ----------------------------------------------------------------------------------------------
>
>                 Key: WW-2104
>                 URL: https://issues.apache.org/struts/browse/WW-2104
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Portlet Integration
>            Reporter: Nils-Helge Garli
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.0
>
>
> Since there is no wrapping of the render request when dispatching to the JSPs, request attributes will not be resolved from the value stack, and tags such as displaytag won't work unless objects are explicitly put on the request as an attribute.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (WW-2104) Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41801 ] 

jholmes edited comment on WW-2104 at 8/11/07 4:02 PM:
-----------------------------------------------------------

Many thanks for opening the ticket and putting together the initial code! I am testing it now and it is working for me using Jetspeed 2. The Displaytag library is now picking up objects on the valuestack.

One thing I noticed though is that you have to define the DispatcherServlet in web.xml using the specific name "dispatcherServlet". I'm wondering if there is a way to make this dynamic. By that I mean that you can use any name for the servlet and the Struts 2 portlet code will automatically find the servlet. If not, I propose we make the name be something like "Struts2PortletDispatcherServlet" that is more descriptive and less likely to have any name conflict with another servlet someone might have.

      was (Author: jholmes):
    Many thanks for opening the ticket and putting together the initial code! I am testing it now and it is working for me. The Displaytag library is now picking up objects on the valuestack.

One thing I noticed though is that you have to define the DispatcherServlet in web.xml using the specific name "dispatcherServlet". I'm wondering if there is a way to make this dynamic. By that I mean that you can use any name for the servlet and the Struts 2 portlet code will automatically find the servlet. If not, I propose we make the name be something like "Struts2PortletDispatcherServlet" that is more descriptive and less likely to have any name conflict with another servlet someone might have.
  
> Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack
> ----------------------------------------------------------------------------------------------
>
>                 Key: WW-2104
>                 URL: https://issues.apache.org/struts/browse/WW-2104
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Portlet Integration
>            Reporter: Nils-Helge Garli
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.0
>
>
> Since there is no wrapping of the render request when dispatching to the JSPs, request attributes will not be resolved from the value stack, and tags such as displaytag won't work unless objects are explicitly put on the request as an attribute.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2104) Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

James Holmes updated WW-2104:
-----------------------------

    Fix Version/s:     (was: Future)
                   2.1.0

> Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack
> ----------------------------------------------------------------------------------------------
>
>                 Key: WW-2104
>                 URL: https://issues.apache.org/struts/browse/WW-2104
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Portlet Integration
>            Reporter: Nils-Helge Garli
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.0
>
>
> Since there is no wrapping of the render request when dispatching to the JSPs, request attributes will not be resolved from the value stack, and tags such as displaytag won't work unless objects are explicitly put on the request as an attribute.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2104) Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41898 ] 

Nils-Helge Garli commented on WW-2104:
--------------------------------------

I have Implemented suggested improvments to naming and configuration, so I'm setting this issue to resolved.

> Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack
> ----------------------------------------------------------------------------------------------
>
>                 Key: WW-2104
>                 URL: https://issues.apache.org/struts/browse/WW-2104
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Portlet Integration
>            Reporter: Nils-Helge Garli
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.0
>
>
> Since there is no wrapping of the render request when dispatching to the JSPs, request attributes will not be resolved from the value stack, and tags such as displaytag won't work unless objects are explicitly put on the request as an attribute.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2104) Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack

Posted by "James Holmes (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41802 ] 

James Holmes commented on WW-2104:
----------------------------------

Nils-H, I'm not sure if you knew this or not, but Spring MVC is using a similar dispatcher servlet technique for handling the view for portlets. See this page:

http://www.springframework.org/docs/reference/portlet.html

Section 16.3. The ViewRendererServlet explains this.

> Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack
> ----------------------------------------------------------------------------------------------
>
>                 Key: WW-2104
>                 URL: https://issues.apache.org/struts/browse/WW-2104
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Portlet Integration
>            Reporter: Nils-Helge Garli
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.0
>
>
> Since there is no wrapping of the render request when dispatching to the JSPs, request attributes will not be resolved from the value stack, and tags such as displaytag won't work unless objects are explicitly put on the request as an attribute.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2104) Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack

Posted by "Nils-Helge Garli (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_41803 ] 

Nils-Helge Garli commented on WW-2104:
--------------------------------------

Yes, we should probably rename it in the web.xml, and even allow for a configuration in case the user wants to control the name. 

I know several portlet frameworks use servlets to render the results, so it's probably safe. 

> Need to create StrutsRequestWrapper objects to resolve request attributes from the value stack
> ----------------------------------------------------------------------------------------------
>
>                 Key: WW-2104
>                 URL: https://issues.apache.org/struts/browse/WW-2104
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Portlet Integration
>            Reporter: Nils-Helge Garli
>            Assignee: Nils-Helge Garli
>             Fix For: 2.1.0
>
>
> Since there is no wrapping of the render request when dispatching to the JSPs, request attributes will not be resolved from the value stack, and tags such as displaytag won't work unless objects are explicitly put on the request as an attribute.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.