[GitHub] [commons-compress] mkoncek commented on pull request #389: Change source encoding to UTF-8

["mkoncek (via GitHub)" <gi...@apache.org>]

mkoncek commented on PR #389:
URL: https://github.com/apache/commons-compress/pull/389#issuecomment-1576651634

   maven-compiler-plugin is declared in `commons-parent` which also uses the `encoding` field. I rebased the PR so that the build reports an error the same way as `javac` would in our case. I don't know why the build doesn't fail, but there is an `[ERROR]` in the log if encoding is set and current sources are used.
   
   `commons-parent` uses ISO-8859 encoding by default.
   
   @sebbASF That would work too, but I believe it is time we can afford such luxury as using non-ASCII-only characters in sources.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org