You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by ja...@apache.org on 2021/09/17 02:13:29 UTC

[pinot] branch master updated: Add aws sts dependency to enable auth using web identity token (#7445)

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new 6a7cbf1  Add aws sts dependency to enable auth using web identity token (#7445)
6a7cbf1 is described below

commit 6a7cbf1fce4ae2565a3968b19f60d9219b7a2424
Author: Abhijeet Kushe <ab...@users.noreply.github.com>
AuthorDate: Thu Sep 16 22:13:16 2021 -0400

    Add aws sts dependency to enable auth using web identity token (#7445)
    
    WebIdentityTokenFileCredentialsProvider needs sts dependency in its classpath
---
 .../pinot-stream-ingestion/pinot-kinesis/pom.xml   | 37 +++++++++++++++++++++-
 1 file changed, 36 insertions(+), 1 deletion(-)

diff --git a/pinot-plugins/pinot-stream-ingestion/pinot-kinesis/pom.xml b/pinot-plugins/pinot-stream-ingestion/pinot-kinesis/pom.xml
index 332417e..5ae3aea 100644
--- a/pinot-plugins/pinot-stream-ingestion/pinot-kinesis/pom.xml
+++ b/pinot-plugins/pinot-stream-ingestion/pinot-kinesis/pom.xml
@@ -117,6 +117,30 @@
     </dependency>
 
     <dependency>
+      <groupId>software.amazon.awssdk</groupId>
+      <artifactId>sts</artifactId>
+      <version>${aws.version}</version>
+      <exclusions>
+        <exclusion>
+          <groupId>io.netty</groupId>
+          <artifactId>netty-codec</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>io.netty</groupId>
+          <artifactId>netty-buffer</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>io.netty</groupId>
+          <artifactId>netty-transport</artifactId>
+        </exclusion>
+        <exclusion>
+          <groupId>io.netty</groupId>
+          <artifactId>netty-common</artifactId>
+        </exclusion>
+      </exclusions>
+    </dependency>
+
+    <dependency>
       <groupId>org.reactivestreams</groupId>
       <artifactId>reactive-streams</artifactId>
     </dependency>
@@ -183,9 +207,20 @@
                   <goal>shade</goal>
                 </goals>
                 <configuration>
-                  <transformers>
+                  <!-- combine.self="override" needs to be specified as without this attribute child pom appears to merge
+                   shade plugin configurations in its parents pom.Notably the shade plugin configuration in the root pom declares a mainClass which 
+                   causes the build to fail - https://github.com/apache/pinot/blob/master/pom.xml#L1880
+                   The build will fail with the message "Unable to parse configuration of mojo org.apache.maven.plugins:maven-shade-plugin:3.2.1:shade 
+                   for parameter mainClass: Cannot find 'mainClass' in class org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" error
+                   Adding "combine.self" attribute in the child pom's configuration will allow maven to execute the shade plugin independently from the
+                   parent pom. For more details please see https://github.com/stevenschlansker/maven-configure-transformer-bug & 
+                   https://mail-archives.apache.org/mod_mbox/maven-issues/201605.mbox/%3CJIRA.12964833.1462316804000.103574.1462316952817@Atlassian.JIRA%3E
+                   -->
+                  <transformers combine.self="override">
                     <transformer
                         implementation="org.apache.maven.plugins.shade.resource.ApacheLicenseResourceTransformer"/>
+                    <transformer
+                        implementation="org.apache.maven.plugins.shade.resource.ServicesResourceTransformer" />
                   </transformers>
                   <!--
                   Usually in hadoop environment, there are multiple jars with different versions.

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org